[PATCH] of/platform: dynamic: Use of_platform_bus_create() to create devices
From: Alexander Sverdlin <hidden>
Date: 2016-10-20 11:02:46
Subsystem:
open firmware and flattened device tree, the rest · Maintainers:
Rob Herring, Saravana Kannan, Linus Torvalds
of_platform_notify() requires parents to have OF_POPULATED_BUS to be set (which is correct way to verify healthy platform bus), but uses of_platform_device_create() to create devices, which never sets the above flag. Therefore it's not possible to add platform buses via overlays. Use of_platform_bus_create(), which is used in non-overlay case to populate both buses and devices. Signed-off-by: Alexander Sverdlin <redacted> Cc: Rob Herring <redacted> Cc: Frank Rowand <redacted> Cc: Pantelis Antoniou <pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org> Cc: Grant Likely <redacted> --- drivers/of/platform.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index af98343..d2d6e74 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c@@ -521,6 +521,7 @@ static int of_platform_notify(struct notifier_block *nb, struct of_reconfig_data *rd = arg; struct platform_device *pdev_parent, *pdev; bool children_left; + int ret; switch (of_reconfig_get_state_change(action, rd)) { case OF_RECONFIG_CHANGE_ADD:
@@ -534,15 +535,15 @@ static int of_platform_notify(struct notifier_block *nb, /* pdev_parent may be NULL when no bus platform device */ pdev_parent = of_find_device_by_node(rd->dn->parent); - pdev = of_platform_device_create(rd->dn, NULL, - pdev_parent ? &pdev_parent->dev : NULL); + ret = of_platform_bus_create(rd->dn, of_default_bus_match_table, + NULL, pdev_parent ? + &pdev_parent->dev : NULL, true); of_dev_put(pdev_parent); - if (pdev == NULL) { + if (ret) { pr_err("%s: failed to create for '%s'\n", __func__, rd->dn->full_name); - /* of_platform_device_create tosses the error code */ - return notifier_from_errno(-EINVAL); + return notifier_from_errno(ret); } break; --
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html