# Re: \[v15, 6/7\] base: soc: introduce soc\_device\_match() interface

- From: Arnd Bergmann \<hidden\>
- Date: 2016-10-28 10:48:57 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2016/10/4863851
- Thread: https://ratatoskr.run/linuxppc-dev/2016/10/4863665/t.md

```text
On Friday, October 28, 2016 2:50:17 PM CEST Yangbo Lu wrote:
> +
> +static int soc_device_match_one(struct device *dev, void *arg)
> +{
> +       struct soc_device *soc_dev = container_of(dev, struct soc_device, dev);
> +       const struct soc_device_attribute *match = arg;
> +
> +       if (match->machine &&
> +           !glob_match(match->machine, soc_dev->attr->machine))
> +               return 0;
> +
> +       if (match->family &&
> +           !glob_match(match->family, soc_dev->attr->family))
> +               return 0;
> +
> 

Geert found a bug in my code, and submitted a fix at
https://patchwork.kernel.org/patch/9361395/

I think you should include that one in your series.

	Arnd
```