# Re: \[PATCH v6 0/3\] mfd: tps65217: Add power-button and IRQ support

- From: Geert Uytterhoeven \<hidden\>
- Date: 2016-09-14 08:37:37 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2016/09/8128149
- Thread: https://ratatoskr.run/linux-devicetree/2016/09/8128149/t.md

```text
On Fri, Sep 9, 2016 at 10:42 AM, Marcin Niestroj
[ref] wrote:
> The following patches add tps65217 power button support and make it usable
> with am335x boards. It was developed and rebased on v4.8-rc5.
>
> Changes v5 -> v6 (suggested by Dmitry):
>  * Use dev_get_regmap() instead of fragile pointer calculations
>  * Keep old formatting for flags as single function argument
>
> Changes v4 -> v5:
>  * Dropped two patches (they were already dropped in v4 resend):
>    * "power_supply: tps65217-charger: Fix NULL deref during property export"
>      (already in mainline)
>    * "power_supply: tps65217-charger: Add support for IRQs" (queued into
>      power-supply's -next branch)
>  * Combine tps65217 and tps65218 power button drivers (as suggested by Dmitry)
>  * Combine device-tree documentation for tps65217 and tps65218 power buttons
>
> Changes v3 -> v4:
>  * Add irq_set_parent() during irq init (suggested by Grygorii)

irq_set_parent() is not exported to modules

ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!

See e.g. http://kisskb.ellerman.id.au/kisskb/buildresult/12801307/

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
```
