Re: [PATCH v2 3/4] gpu: drm: exynos_hdmi: Use consolidated function on binding DDC DT property
From: Milo Kim <hidden>
Date: 2016-08-24 07:21:39
Also in:
dri-devel, linux-arm-kernel, linux-samsung-soc, lkml
Hi Andrzej, On 08/24/2016 02:55 PM, Andrzej Hajda wrote:
This is mistake introduced by other patch, of_node_put should be called on np, after calling of_find_i2c_adapter_by_node. You can fix it in your patch as well. I think you can move of_find_i2c_adapter_by_node also to this function and rename it to sth like hdmi_get_ddc_adapter, this way you will enclose whole logic of getting resource into one function.
Agree, let me prepare next patch-set. Thanks! Best regards, Milo _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel