RE: [RFC 1/2] Dcumentation: bridge: Add documentation for ps8640 DT properties

Hi, Rob:

-----Original Message-----
From: Rob Herring [mailto:robh+dt@kernel.org]
Sent: Friday, October 16, 2015 9:22 PM
Subject: Re: [RFC 1/2] Dcumentation: bridge: Add documentation for

ps8640

DT properties

On Fri, Oct 16, 2015 at 7:15 AM, CK Hu [off-list ref] wrote:

quoted

From: Jitao Shi <redacted>

Add documentation for DT properties supported by ps8640 DSI-eDP
converter.

Signed-off-by: Jitao Shi <redacted>
---
 .../devicetree/bindings/video/bridge/ps8640.txt    |   48

++++++++++++++++++++

Please move to bindings/display/bridge/.

ok, we will move ps8640.txt to bindings/display/bridge/

quoted

 1 file changed, 48 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/video/bridge/ps8640.txt

diff --git

a/Documentation/devicetree/bindings/video/bridge/ps8640.txt

quoted

b/Documentation/devicetree/bindings/video/bridge/ps8640.txt
new file mode 100644
index 0000000..450b5df

--- /dev/null
+++ b/Documentation/devicetree/bindings/video/bridge/ps8640.txt

@@ -0,0 +1,48 @@
+ps8640-bridge bindings
+
+Required properties:
+       - compatible: "parade,ps8640"
+       - reg: first i2c address of the bridge
+       - power-gpios: OF device-tree gpio specification for power

pin.

quoted

+       - reset-gpios: OF device-tree gpio specification for reset

pin.

quoted

+       - mode-sel-gpios: OF device-tree gpio specification for

mode-sel

pin.

quoted

+       - ps8640-1v2-supply: OF device-tree regulator specification

for

1v2.

quoted

+       - ps8640-3v3-supply: OF device-tree regulator specification

for

3v3.

As others have said, I would drop the part number and name them based

on

the supply name (e.g. vdd?, vcore?).

yes, we should use vdd12-supply and vdd33-supply, we'll fixed it in next
patch.

quoted

+
+Optional properties:
+       - video interfaces: Device node can contain video interface

port

quoted

+                           nodes for panel according to [1].

I don't think this should be optional.

yes, we will fix it in next patch.

quoted