# Re: \[PATCH v4 01/22\] driver core: Add pre\_probe callback to bus\_type

- From: Mark Brown \<broonie@kernel.org\>
- Date: 2015-09-11 12:04:38 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2015/09/4573609
- Thread: https://ratatoskr.run/linux-arm-kernel/2015/09/4570863/t.md

```text
On Mon, Sep 07, 2015 at 02:23:26PM +0200, Tomeu Vizoso wrote:

> +	if (dev->bus && dev->bus->pre_probe) {
> +		ret = dev->bus->pre_probe(dev);
> +		if (ret) {
> +			if (ret == -EPROBE_DEFER)
> +				driver_deferred_probe_add(dev);
> +			ret = 0;
> +			goto out_unlock;
> +		}
> +	}

So if we get an error other than -EPROBE_DEFER we silently ignore it?
That seems surprising and at least worth a comment.

> +	if (dev->bus && dev->bus->pre_probe) {
> +		ret = dev->bus->pre_probe(dev);
> +		if (ret) {
> +			if (ret == -EPROBE_DEFER)
> +				driver_deferred_probe_add(dev);
> +			goto out;
> +		}
> +	}

That's more what I'd expect.
```

## Attachments

- [signature.asc](https://ratatoskr.run/linux-devicetree/2015/09/4573609/attachment/0) (application/pgp-signature, 473 bytes)
