Thanks Stephen for the comments.

On 14/07/15 22:18, Stephen Boyd wrote:

On 07/10, Srinivas Kandagatla wrote:

quoted

This patch adds QFPROM support driver which is used by other drivers
like thermal sensor and cpufreq.

On MSM parts there are some efuses (called qfprom) these fuses store
things like calibration data, speed bins.. etc. Drivers like cpufreq,
thermal sensors would read out this data for configuring the driver.

Signed-off-by: Srinivas Kandagatla <redacted>
---

I didn't see any reply on v6, but at least delay.h was removed.
Same comments from v6 below.

Sorry I think I forgot to reply you on v6.

quoted

diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
new file mode 100644
index 0000000..0e22a03
--- /dev/null
+++ b/drivers/nvmem/qfprom.c

@@ -0,0 +1,87 @@
+/*
+ * Copyright (C) 2015 Srinivas Kandagatla <srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 and
+ * only version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <linux/device.h>
+#include <linux/io.h>

Is this include used?

No, I don't think so, I will remove it.

quoted

+#include <linux/module.h>
+#include <linux/nvmem-provider.h>
+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+#include <linux/slab.h>
+
+static struct regmap_config qfprom_regmap_config = {

Can this be const?

No, regmap config max_register is updated in the probe so we cant have 
this as constant.

quoted

+	.reg_bits = 32,
+	.val_bits = 8,
+	.reg_stride = 1,
+};
+
+static struct nvmem_config econfig = {

Can this be const?

Same here, dev pointer is updated in probe so we can't make this constant.

quoted

+	.name = "qfprom",
+	.owner = THIS_MODULE,
+};
+