Re: [PATCH-V5 3/4] mfd: 88pm800: Set default interrupt clear method
From: Krzysztof Kozlowski <hidden>
Date: 2015-06-30 00:29:34
Also in:
linux-arm-kernel, lkml
From: Krzysztof Kozlowski <hidden>
Date: 2015-06-30 00:29:34
Also in:
linux-arm-kernel, lkml
2015-06-30 0:31 GMT+09:00 Vaibhav Hiremath [off-list ref]:
As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe (page 0) controls the method of clearing interrupt status of 88pm800 family of devices; 0: clear on read 1: clear on write If pdata is not coming from board file, then set the default irq clear method to "irq clear on write" Also, as suggested by "Lee Jones" renaming variable field to appropriate name. Signed-off-by: Zhao Ye <redacted> Signed-off-by: Vaibhav Hiremath <redacted> --- drivers/mfd/88pm800.c | 15 ++++++++++----- include/linux/mfd/88pm80x.h | 10 ++++++++-- 2 files changed, 18 insertions(+), 7 deletions(-)
Looks fine to me. Reviewed-by: Krzysztof Kozlowski <redacted> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html