From: Caesar Wang <hidden> Date: 2015-06-16 07:28:29
The original driver is uploaded by Jianqun.
Here is his patchs:
https://patchwork.kernel.org/patch/5410341/https://patchwork.kernel.org/patch/5410351/
Jianqun, nevermind!
I check-pick it and re-upload the driver for the upstream.
e.g.:
Tested by on minnie board.(kernel-4.1-rc8)
cd /sys/devices/platform/ffb40000.efuse
localhost ffb40000.efuse # cat cpu_leakage_show
cpu_version_show
The results:
19
2
Changes in v2:
- Change the document decription.
- Move the efuse driver into driver/soc/vendor.
- update the efuse driver.
- Add the dts node on RK3288.
Caesar Wang (3):
soc/rockchip: Add efuse bindings for Rockchip SoC efuse driver
soc/rockchip: efuse: Add Rockchip SoC efuse support
ARM: dts: Add RK3288 efuse node
.../bindings/fuse/rockchip,rockchip-efuse.txt | 14 ++
arch/arm/boot/dts/rk3288.dtsi | 5 +
drivers/soc/Makefile | 1 +
drivers/soc/rockchip/Makefile | 4 +
drivers/soc/rockchip/efuse.c | 212 +++++++++++++++++++++
5 files changed, 236 insertions(+)
create mode 100644 Documentation/devicetree/bindings/fuse/rockchip,rockchip-efuse.txt
create mode 100644 drivers/soc/rockchip/Makefile
create mode 100644 drivers/soc/rockchip/efuse.c
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
@@ -0,0 +1,14 @@+ROCKCHIP RK3066/RK3188/RK3288/RK3368 efuse block.++Required properties:+- compatible : should be: "rockchip,<name>-efuse"+ "rockchip,rk3066-efuse": found on RK3066,RK3188,RK3288 and RK3368.+- reg: Should contain 1 entry: the entry gives the physical address and length+ of the fuse registers.++Example:++ efuse: efuse@ffb40000 {+ compatible = "rockchip,rk3066-efuse";+ reg = <0xffb40000 0x10000>;+ };
From: Caesar Wang <hidden> Date: 2015-06-16 07:28:52
Add driver for efuse found on Rockchip RK3066,RK3188,RK3288 and
RK3368 SoCs.
eFuse is organized as 32bits by 8 one-time programmable
electrical fuses with random access interface.
Signed-off-by: Jianqun Xu <redacted>
Signed-off-by: Caesar Wang <redacted>
---
Changes in v2:
- Move the efuse driver into driver/soc/vendor.
- update the efuse driver.
drivers/soc/Makefile | 1 +
drivers/soc/rockchip/Makefile | 4 +
drivers/soc/rockchip/efuse.c | 212 ++++++++++++++++++++++++++++++++++++++++++
3 files changed, 217 insertions(+)
create mode 100644 drivers/soc/rockchip/Makefile
create mode 100644 drivers/soc/rockchip/efuse.c
From: Caesar Wang <hidden> Date: 2015-06-16 07:29:06
Add the efuse node on RK3288, we can get some information
when enable the efuse driver.
e.g.: the CPU version, leakage.....
Signed-off-by: Caesar Wang <redacted>
---
Changes in v2:
- Add the dts node on RK3288.
arch/arm/boot/dts/rk3288.dtsi | 5 +++++
1 file changed, 5 insertions(+)
From: Stefan Wahren <hidden> Date: 2015-06-16 08:54:21
Hi Caesar,
[add Maxime and Srinivas]
Am 16.06.2015 um 09:27 schrieb Caesar Wang:
The original driver is uploaded by Jianqun.
Here is his patchs:
https://patchwork.kernel.org/patch/5410341/https://patchwork.kernel.org/patch/5410351/
Jianqun, nevermind!
I check-pick it and re-upload the driver for the upstream.
e.g.:
Tested by on minnie board.(kernel-4.1-rc8)
cd /sys/devices/platform/ffb40000.efuse
localhost ffb40000.efuse # cat cpu_leakage_show
cpu_version_show
The results:
19
2
Changes in v2:
- Change the document decription.
- Move the efuse driver into driver/soc/vendor.
- update the efuse driver.
- Add the dts node on RK3288.
i want to mention that there is a upcoming new framework suitable for
efuse drivers:
https://lkml.org/lkml/2015/5/21/643
Unfortunately i don't know the current development state.
Regards
Stefan
Hi Stefan,
On 16/06/15 09:52, Stefan Wahren wrote:
Hi Caesar,
[add Maxime and Srinivas]
Am 16.06.2015 um 09:27 schrieb Caesar Wang:
quoted
The original driver is uploaded by Jianqun.
Here is his patchs:
https://patchwork.kernel.org/patch/5410341/https://patchwork.kernel.org/patch/5410351/
Jianqun, nevermind!
I check-pick it and re-upload the driver for the upstream.
e.g.:
Tested by on minnie board.(kernel-4.1-rc8)
cd /sys/devices/platform/ffb40000.efuse
localhost ffb40000.efuse # cat cpu_leakage_show
cpu_version_show
The results:
19
2
Changes in v2:
- Change the document decription.
- Move the efuse driver into driver/soc/vendor.
- update the efuse driver.
- Add the dts node on RK3288.
i want to mention that there is a upcoming new framework suitable for
efuse drivers:
https://lkml.org/lkml/2015/5/21/643
Unfortunately i don't know the current development state.
Currently this framework is used by atleast 3 drivers(qcom-tsens, qcom-cpr, begel-bone-cape manager) which are still floating in the mailing list.
I was hoping that these 3 users would getback with tested-by.. which did not happen for last 3-4 weeks.
I would appreciate, If you could try framework too, and let me know.
I added two of wrappers on top of v5 at: https://git.linaro.org/people/srinivas.kandagatla/linux.git/shortlog/refs/heads/nvmem-dev-v5
I think I should request Mark to take the framework.
--srini
From: Caesar Wang <hidden> Date: 2015-06-16 10:06:28
Hi Srinivas,
在 2015年06月16日 17:21, Srinivas Kandagatla 写道:
Hi Stefan,
On 16/06/15 09:52, Stefan Wahren wrote:
quoted
Hi Caesar,
[add Maxime and Srinivas]
Am 16.06.2015 um 09:27 schrieb Caesar Wang:
quoted
The original driver is uploaded by Jianqun.
Here is his patchs:
https://patchwork.kernel.org/patch/5410341/https://patchwork.kernel.org/patch/5410351/
Jianqun, nevermind!
I check-pick it and re-upload the driver for the upstream.
e.g.:
Tested by on minnie board.(kernel-4.1-rc8)
cd /sys/devices/platform/ffb40000.efuse
localhost ffb40000.efuse # cat cpu_leakage_show
cpu_version_show
The results:
19
2
Changes in v2:
- Change the document decription.
- Move the efuse driver into driver/soc/vendor.
- update the efuse driver.
- Add the dts node on RK3288.
i want to mention that there is a upcoming new framework suitable for
efuse drivers:
https://lkml.org/lkml/2015/5/21/643
Unfortunately i don't know the current development state.
Currently this framework is used by atleast 3 drivers(qcom-tsens, qcom-cpr, begel-bone-cape manager) which are still floating in the mailing list.
I was hoping that these 3 users would getback with tested-by.. which did not happen for last 3-4 weeks.
I would appreciate, If you could try framework too, and let me know.
Okay,
I will do that...
Doing.....
203d56b WIP: nvmem: add device tree helper functions
7d822d7 nvmem: sunxi: Move the SID driver to the nvmem framework
f54130d nvmem: qfprom: Add bindings for qfprom
6e078d2 nvmem: qfprom: Add Qualcomm QFPROM support.
750d32b nvmem: Add simple nvmem-mmio consumer helper functions.
6390111 nvmem: Add bindings for simple nvmem framework
1c02217 nvmem: Add nvmem_device based consumer apis.
61ce74f nvmem: Add a simple NVMEM framework for consumers
0f82237 nvmem: Add a simple NVMEM framework for nvmem providers
7547598 regmap: Introduce regmap_get_reg_stride.
f3bc1c0 regmap: Introduce regmap_get_max_register.
f0b3b70 ARM: rockchip: fix the SMP code style
8a28ee6 ARM: rockchip: ensure CPU to enter WFI/WFE state
609deeb ARM: rockchip: fix the CPU soft reset
2a876e4 ARM: rockchip: restore dapswjdp after suspend
e260818 Linux 4.1-rc4
ab992dc watchdog: Fix merge 'conflict'
....
At the moment, I don't know how to use this framework.
I need some time to dig it, I'm happy if you some reference(driver or document).
Hi Srinivas,
在 2015年06月16日 17:21, Srinivas Kandagatla 写道:
quoted
Hi Stefan,
On 16/06/15 09:52, Stefan Wahren wrote:
quoted
Hi Caesar,
[add Maxime and Srinivas]
Am 16.06.2015 um 09:27 schrieb Caesar Wang:
quoted
The original driver is uploaded by Jianqun.
Here is his patchs:
https://patchwork.kernel.org/patch/5410341/https://patchwork.kernel.org/patch/5410351/
Jianqun, nevermind!
I check-pick it and re-upload the driver for the upstream.
e.g.:
Tested by on minnie board.(kernel-4.1-rc8)
cd /sys/devices/platform/ffb40000.efuse
localhost ffb40000.efuse # cat cpu_leakage_show
cpu_version_show
The results:
19
2
Changes in v2:
- Change the document decription.
- Move the efuse driver into driver/soc/vendor.
- update the efuse driver.
- Add the dts node on RK3288.
i want to mention that there is a upcoming new framework suitable for
efuse drivers:
https://lkml.org/lkml/2015/5/21/643
Unfortunately i don't know the current development state.
Currently this framework is used by atleast 3 drivers(qcom-tsens,
qcom-cpr, begel-bone-cape manager) which are still floating in the
mailing list.
I was hoping that these 3 users would getback with tested-by.. which
did not happen for last 3-4 weeks.
I would appreciate, If you could try framework too, and let me know.
Okay,
I will do that...
Doing.....
203d56b WIP: nvmem: add device tree helper functions
7d822d7 nvmem: sunxi: Move the SID driver to the nvmem framework
f54130d nvmem: qfprom: Add bindings for qfprom
6e078d2 nvmem: qfprom: Add Qualcomm QFPROM support.
750d32b nvmem: Add simple nvmem-mmio consumer helper functions.
6390111 nvmem: Add bindings for simple nvmem framework
1c02217 nvmem: Add nvmem_device based consumer apis.
61ce74f nvmem: Add a simple NVMEM framework for consumers
0f82237 nvmem: Add a simple NVMEM framework for nvmem providers
7547598 regmap: Introduce regmap_get_reg_stride.
f3bc1c0 regmap: Introduce regmap_get_max_register.
f0b3b70 ARM: rockchip: fix the SMP code style
8a28ee6 ARM: rockchip: ensure CPU to enter WFI/WFE state
609deeb ARM: rockchip: fix the CPU soft reset
2a876e4 ARM: rockchip: restore dapswjdp after suspend
e260818 Linux 4.1-rc4
ab992dc watchdog: Fix merge 'conflict'
....
At the moment, I don't know how to use this framework.
I need some time to dig it, I'm happy if you some reference(driver or
document).
These are very simple apis which are listed in nvmem-consumer.h nvmem-provider.h. I will try to come up with some doc very soon.. thanks for your patience.
I just had a look at the efuse driver and all you need is(I did not do any compile testing) : Have a look at qfprom.c file, the drivers are based on regmap, so you get lot of flexibility to add custom reads/caches and lot of other regmap features.
dt:
/* Provider */
efuse: efuse@ffb40000 {
compatible = "rockchip,rk3066-efuse";
reg = <0xffb40000 0x10000>;
cpu_leakage: cpu_leakage {
reg = <17 0x4>;
};
chip_version: chip_version {
reg = <0x6 0x1>;
};
};
/* Consumer dt: */
consumer-driver@0 {
nvmem-cell = <&cpu_leakage>;
nvmem-cell-names = "cpu-leakage";
};
/ * consumer driver */
nvmem_cell_get()/nvmem_cell_put();
nvmem_cell_read()/nvmem_cell_write();
/* Provider driver */ : drivers/nvmem/rockchip_efuse.c
#include <linux/module.h>
#include <linux/of.h>
#include "nvmem-mmio.h"
int rockchip_efuse_reg_read(void *context, unsigned int reg, unsigned int *val)
{
/* efuse specific read sequence */
...
}
static struct regmap_config rockchip_efuse_regmap_config = {
.reg_bits = 32,
.val_bits = 8,
.reg_stride = 1,
.reg_read = rockchip_efuse_reg_read,
};
static struct nvmem_config econfig = {
.name = "rockchip-efuse",
.owner = THIS_MODULE,
};
static struct nvmem_mmio_data rockchip_efuse_data = {
.nvmem_config = &econfig,
.regmap_config = &rockchip_efuse_regmap_config,
};
static const struct of_device_id rockchip_efuse_of_match[] = {
{ .compatible = "rockchip,rk3066-efuse", .data = &rockchip_efuse_data},
{/* sentinel */},
};
MODULE_DEVICE_TABLE(of, rockchip_efuse_of_match);
static struct platform_driver rockchip_efuse_driver = {
.probe = nvmem_mmio_probe,
.remove = nvmem_mmio_remove,
.driver = {
.name = "rockchip_efuse",
.of_match_table = rockchip_efuse_of_match,
},
};
module_platform_driver(rockchip_efuse_driver);
MODULE_DESCRIPTION("rockchip_efuse driver");
MODULE_LICENSE("GPL v2");
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Stefan Wahren <hidden> Date: 2015-06-18 07:05:58
Hi Srinivas,
Am 16.06.2015 um 12:54 schrieb Srinivas Kandagatla:
On 16/06/15 11:06, Caesar Wang wrote:
quoted
Hi Srinivas,
在 2015年06月16日 17:21, Srinivas Kandagatla 写道:
quoted
Hi Stefan,
On 16/06/15 09:52, Stefan Wahren wrote:
quoted
Hi Caesar,
[add Maxime and Srinivas]
Am 16.06.2015 um 09:27 schrieb Caesar Wang:
quoted
The original driver is uploaded by Jianqun.
Here is his patchs:
https://patchwork.kernel.org/patch/5410341/https://patchwork.kernel.org/patch/5410351/
Jianqun, nevermind!
I check-pick it and re-upload the driver for the upstream.
e.g.:
Tested by on minnie board.(kernel-4.1-rc8)
cd /sys/devices/platform/ffb40000.efuse
localhost ffb40000.efuse # cat cpu_leakage_show
cpu_version_show
The results:
19
2
Changes in v2:
- Change the document decription.
- Move the efuse driver into driver/soc/vendor.
- update the efuse driver.
- Add the dts node on RK3288.
i want to mention that there is a upcoming new framework suitable for
efuse drivers:
https://lkml.org/lkml/2015/5/21/643
Unfortunately i don't know the current development state.
Currently this framework is used by atleast 3 drivers(qcom-tsens,
qcom-cpr, begel-bone-cape manager) which are still floating in the
mailing list.
I was hoping that these 3 users would getback with tested-by.. which
did not happen for last 3-4 weeks.
I would appreciate, If you could try framework too, and let me know.
yes i work on OCOTP driver for MXS platform and i will try ...
int rockchip_efuse_reg_read(void *context, unsigned int reg, unsigned
int *val)
{
/* efuse specific read sequence */
...
}
I will need a specific read sequence too.
Sorry for these newbie questions:
What data structure does context points to for this reg_read opteration?
Do we need range checking of reg or is it handled by the framework?
Are there any limitation for reg_read regarding sleeping or locking
operations?
In case of a read only driver, is everything handle by devicetree or do
we need an empty write operation?
Best regards
Stefan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Srinivas,
Am 16.06.2015 um 12:54 schrieb Srinivas Kandagatla:
quoted
On 16/06/15 11:06, Caesar Wang wrote:
quoted
Hi Srinivas,
在 2015年06月16日 17:21, Srinivas Kandagatla 写道:
quoted
Hi Stefan,
On 16/06/15 09:52, Stefan Wahren wrote:
quoted
Hi Caesar,
[add Maxime and Srinivas]
Am 16.06.2015 um 09:27 schrieb Caesar Wang:
quoted
The original driver is uploaded by Jianqun.
Here is his patchs:
https://patchwork.kernel.org/patch/5410341/https://patchwork.kernel.org/patch/5410351/
Jianqun, nevermind!
I check-pick it and re-upload the driver for the upstream.
e.g.:
Tested by on minnie board.(kernel-4.1-rc8)
cd /sys/devices/platform/ffb40000.efuse
localhost ffb40000.efuse # cat cpu_leakage_show
cpu_version_show
The results:
19
2
Changes in v2:
- Change the document decription.
- Move the efuse driver into driver/soc/vendor.
- update the efuse driver.
- Add the dts node on RK3288.
i want to mention that there is a upcoming new framework suitable for
efuse drivers:
https://lkml.org/lkml/2015/5/21/643
Unfortunately i don't know the current development state.
Currently this framework is used by atleast 3 drivers(qcom-tsens,
qcom-cpr, begel-bone-cape manager) which are still floating in the
mailing list.
I was hoping that these 3 users would getback with tested-by.. which
did not happen for last 3-4 weeks.
I would appreciate, If you could try framework too, and let me know.
yes i work on OCOTP driver for MXS platform and i will try ...
quoted
int rockchip_efuse_reg_read(void *context, unsigned int reg, unsigned
int *val)
{
/* efuse specific read sequence */
...
}
Sorry for these newbie questions:
What data structure does context points to for this reg_read opteration?
Do we need range checking of reg or is it handled by the framework?
We already have that in place.
Are there any limitation for reg_read regarding sleeping or locking
operations?
There are no limitaions as such from nvmem framework, regmap might have limitations w.r.t to sleeping and fast_io, as fast_io would take spinlocks, AFAIK the providers would not have fast_io, as they not IO devices.
In case of a read only driver, is everything handle by devicetree or do
we need an empty write operation?
Yes, if you pass read-only flag in the provider, the framework would not attempt to even write.
You will find answers to most of your question in the rochip-efuse.c file.
--srini
From: Caesar Wang <hidden> Date: 2015-06-18 09:08:35
在 2015年06月18日 16:29, Srinivas Kandagatla 写道:
On 18/06/15 08:05, Stefan Wahren wrote:
quoted
Hi Srinivas,
Am 16.06.2015 um 12:54 schrieb Srinivas Kandagatla:
quoted
On 16/06/15 11:06, Caesar Wang wrote:
quoted
Hi Srinivas,
在 2015年06月16日 17:21, Srinivas Kandagatla 写道:
quoted
Hi Stefan,
On 16/06/15 09:52, Stefan Wahren wrote:
quoted
Hi Caesar,
[add Maxime and Srinivas]
Am 16.06.2015 um 09:27 schrieb Caesar Wang:
quoted
The original driver is uploaded by Jianqun.
Here is his patchs:
https://patchwork.kernel.org/patch/5410341/https://patchwork.kernel.org/patch/5410351/
Jianqun, nevermind!
I check-pick it and re-upload the driver for the upstream.
e.g.:
Tested by on minnie board.(kernel-4.1-rc8)
cd /sys/devices/platform/ffb40000.efuse
localhost ffb40000.efuse # cat cpu_leakage_show
cpu_version_show
The results:
19
2
Changes in v2:
- Change the document decription.
- Move the efuse driver into driver/soc/vendor.
- update the efuse driver.
- Add the dts node on RK3288.
i want to mention that there is a upcoming new framework suitable for
efuse drivers:
https://lkml.org/lkml/2015/5/21/643
Unfortunately i don't know the current development state.
Currently this framework is used by atleast 3 drivers(qcom-tsens,
qcom-cpr, begel-bone-cape manager) which are still floating in the
mailing list.
I was hoping that these 3 users would getback with tested-by.. which
did not happen for last 3-4 weeks.
I would appreciate, If you could try framework too, and let me know.
yes i work on OCOTP driver for MXS platform and i will try ...
quoted
int rockchip_efuse_reg_read(void *context, unsigned int reg, unsigned
int *val)
{
/* efuse specific read sequence */
...
}
That rockchip-efuse.c driver shouldn't be work.
An entire 8-bit word of data can be read in one read operation with STROBE being high and a proper address
selected (address signals A5~A7 are “don’t cares”).
That's great if we can get the content from the .reg_read when the consumer driver
callback the nvmem_cell_read().
e.g.:
static struct regmap_config rockchip_efuse_regmap_config = {
.reg_bits = 32,
.val_bits = 8,
.reg_stride = 1,
.reg_read = rockchip_efuse_reg_read,
};
...
/ * consumer driver */
nvmem_cell_get()/nvmem_cell_put();
nvmem_cell_read()/nvmem_cell_write();
........
quoted
Sorry for these newbie questions:
What data structure does context points to for this reg_read opteration?
Do we need range checking of reg or is it handled by the framework?
We already have that in place.
quoted
Are there any limitation for reg_read regarding sleeping or locking
operations?
There are no limitaions as such from nvmem framework, regmap might have limitations w.r.t to sleeping and fast_io, as fast_io would take spinlocks, AFAIK the providers would not have fast_io, as they not IO devices.
quoted
In case of a read only driver, is everything handle by devicetree or do
we need an empty write operation?
Yes, if you pass read-only flag in the provider, the framework would not attempt to even write.
You will find answers to most of your question in the rochip-efuse.c file.
--srini
quoted
Best regards
Stefan
--
Thanks,
- Caesar
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Dear Srinivas,
On 2015年06月18日 16:29, Srinivas Kandagatla wrote:
On 18/06/15 08:05, Stefan Wahren wrote:
quoted
Hi Srinivas,
Am 16.06.2015 um 12:54 schrieb Srinivas Kandagatla:
quoted
On 16/06/15 11:06, Caesar Wang wrote:
quoted
Hi Srinivas,
在 2015年06月16日 17:21, Srinivas Kandagatla 写道:
quoted
Hi Stefan,
On 16/06/15 09:52, Stefan Wahren wrote:
quoted
Hi Caesar,
[add Maxime and Srinivas]
Am 16.06.2015 um 09:27 schrieb Caesar Wang:
quoted
The original driver is uploaded by Jianqun.
Here is his patchs:
https://patchwork.kernel.org/patch/5410341/https://patchwork.kernel.org/patch/5410351/
Jianqun, nevermind!
I check-pick it and re-upload the driver for the upstream.
e.g.:
Tested by on minnie board.(kernel-4.1-rc8)
cd /sys/devices/platform/ffb40000.efuse
localhost ffb40000.efuse # cat cpu_leakage_show
cpu_version_show
The results:
19
2
Changes in v2:
- Change the document decription.
- Move the efuse driver into driver/soc/vendor.
- update the efuse driver.
- Add the dts node on RK3288.
i want to mention that there is a upcoming new framework suitable for
efuse drivers:
https://lkml.org/lkml/2015/5/21/643
Unfortunately i don't know the current development state.
Currently this framework is used by atleast 3 drivers(qcom-tsens,
qcom-cpr, begel-bone-cape manager) which are still floating in the
mailing list.
I was hoping that these 3 users would getback with tested-by.. which
did not happen for last 3-4 weeks.
I would appreciate, If you could try framework too, and let me know.
yes i work on OCOTP driver for MXS platform and i will try ...
quoted
int rockchip_efuse_reg_read(void *context, unsigned int reg, unsigned
int *val)
{
/* efuse specific read sequence */
...
}
I'm testing the rockchip-efuse.c driver based on nvmem framework v8, it works on RK3288-soc except:
1. Without the following diff, `hexdump /sys/bus/nvmem/devices/rockchip-efuse0/nvmem` is wrong with "INVALID ARGUMENT":
+++ b/drivers/nvmem/core.c
@@ -67,7 +67,7 @@ static ssize_t bin_attr_nvmem_read(struct file *filp, struct kobject *kobj,intrc;/* Stop the user from reading */-if(pos>nvmem->size)+if(pos>nvmem->size-1)return0;if(pos+count>nvmem->size)
RK3288-efuse has 32 x 8bit regs, in dts "reg = <0xffb40000 0x20>;"
Here is the message dump from nvmem_device:
[ 2.158314] nvmem:
[ 2.158314] name (null)
[ 2.158314] stride 1
[ 2.158314] word_size 1
[ 2.158314] ncells 0
[ 2.158314] id 0
[ 2.158314] users 0
[ 2.158314] size 32
[ 2.158314] read_only 0
Do you think there is a leak or I'm messing up ?
2. About the read operation, eFuse data can be read during device probe() and cached, OR,
read from eFuse when needed every time. I prefer the second one but then, the clock of eFuse may be
gated. So before/after reading I have to enable/disable clk like :
devm_clk_get(dev, "hclk_efuse256");
The trouble is I can't find a way to get the "dev" hander in :
static int rockchip_efuse_read(void *context, const void *reg, size_t reg_size, void *val, size_t val_size)
I am appreciated if you can give some advice.
Or, do you think it's reasonable to add hooks before/after read in nvmem/core.c like :
+ before_read(dev, ...);
rc = regmap_raw_read(nvmem->regmap, pos, buf, count);
+ after_read(dev, ...);
3. In the /sys/bus/nvmem/devices/rockchip-efuse0/, there are files:
/sys/devices/platform/ffb40000.efuse/rockchip-efuse0 # ls
nvmem of_node power subsystem uevent
Do you have a plan to add the nvmem consumers to /sys/ in nvmem framework?
For example, in dts defined the "cpu_leakage":
efuse: efuse@ffb40000 {
compatible = "rockchip,rk3x-efuse";
reg = <0xffb40000 0x20>;
#address-cells = <1>;
#size-cells = <1>;
clocks = <&cru PCLK_EFUSE256>;
clock-names = "pclk_efuse_256";
cpu_leakage: cpu_leakage {
reg = <0x17 0x1>;
};
};
Then nvmem exposes the "cpu_leakage" file in /sys which can be read/write.
Thank you very much,
Shunqian Zheng
quoted
Sorry for these newbie questions:
What data structure does context points to for this reg_read opteration?
Do we need range checking of reg or is it handled by the framework?
We already have that in place.
quoted
Are there any limitation for reg_read regarding sleeping or locking
operations?
There are no limitaions as such from nvmem framework, regmap might have limitations w.r.t to sleeping and fast_io, as fast_io would take spinlocks, AFAIK the providers would not have fast_io, as they not IO devices.
quoted
In case of a read only driver, is everything handle by devicetree or do
we need an empty write operation?
Yes, if you pass read-only flag in the provider, the framework would not attempt to even write.
You will find answers to most of your question in the rochip-efuse.c file.
--srini
struct kobject *kobj,
int rc;
/* Stop the user from reading */
- if (pos > nvmem->size)
+ if (pos > nvmem->size - 1)
return 0;
Yes, this should have been something like this
- if (pos > nvmem->size)
+ if (pos >= nvmem->size)
return 0;
We can send a fix on top of v9 once its merged.
if (pos + count > nvmem->size)
RK3288-efuse has 32 x 8bit regs, in dts "reg = <0xffb40000 0x20>;"
Here is the message dump from nvmem_device:
[ 2.158314] nvmem:
[ 2.158314] name (null)
[ 2.158314] stride 1
[ 2.158314] word_size 1
[ 2.158314] ncells 0
[ 2.158314] id 0
[ 2.158314] users 0
[ 2.158314] size 32
[ 2.158314] read_only 0
Do you think there is a leak or I'm messing up ?
2. About the read operation, eFuse data can be read during device
probe() and cached, OR,
read from eFuse when needed every time. I prefer the second one but
then, the clock of eFuse may be
gated. So before/after reading I have to enable/disable clk like :
devm_clk_get(dev, "hclk_efuse256");
The trouble is I can't find a way to get the "dev" hander in :
static int rockchip_efuse_read(void *context, const void
*reg, size_t reg_size, void *val, size_t val_size)
I am appreciated if you can give some advice.
May be you should use regmap_init_mmio_clk() instead of regmap_init_mmio() it will take care of clks.
Or, do you think it's reasonable to add hooks before/after read in
nvmem/core.c like :
+ before_read(dev, ...);
rc = regmap_raw_read(nvmem->regmap, pos, buf, count);
+ after_read(dev, ...);
3. In the /sys/bus/nvmem/devices/rockchip-efuse0/, there are files:
/sys/devices/platform/ffb40000.efuse/rockchip-efuse0 # ls
nvmem of_node power subsystem uevent
Do you have a plan to add the nvmem consumers to /sys/ in nvmem
framework?
yes, Am waiting for the framework to be merged, I have plans to add this feature.
For example, in dts defined the "cpu_leakage":
efuse: efuse@ffb40000 {
compatible = "rockchip,rk3x-efuse";
reg = <0xffb40000 0x20>;
#address-cells = <1>;
#size-cells = <1>;
clocks = <&cru PCLK_EFUSE256>;
clock-names = "pclk_efuse_256";
cpu_leakage: cpu_leakage {
reg = <0x17 0x1>;
};
};
Then nvmem exposes the "cpu_leakage" file in /sys which can be
read/write.
struct kobject *kobj,
int rc;
/* Stop the user from reading */
- if (pos > nvmem->size)
+ if (pos > nvmem->size - 1)
return 0;
Yes, this should have been something like this
- if (pos > nvmem->size)
+ if (pos >= nvmem->size)
return 0;
We can send a fix on top of v9 once its merged.
quoted
if (pos + count > nvmem->size)
RK3288-efuse has 32 x 8bit regs, in dts "reg = <0xffb40000 0x20>;"
Here is the message dump from nvmem_device:
[ 2.158314] nvmem:
[ 2.158314] name (null)
[ 2.158314] stride 1
[ 2.158314] word_size 1
[ 2.158314] ncells 0
[ 2.158314] id 0
[ 2.158314] users 0
[ 2.158314] size 32
[ 2.158314] read_only 0
Do you think there is a leak or I'm messing up ?
2. About the read operation, eFuse data can be read during device
probe() and cached, OR,
read from eFuse when needed every time. I prefer the second one but
then, the clock of eFuse may be
gated. So before/after reading I have to enable/disable clk like :
devm_clk_get(dev, "hclk_efuse256");
The trouble is I can't find a way to get the "dev" hander in :
static int rockchip_efuse_read(void *context, const void
*reg, size_t reg_size, void *val, size_t val_size)
I am appreciated if you can give some advice.
May be you should use regmap_init_mmio_clk() instead of regmap_init_mmio() it will take care of clks.
Thank you for you reply.
Although the regmap_init_mmio_clk() and it's series interface deal with the clks, but
MMIO uses its own regmap_bus{}, while the eFuse of RK3X need special read/write
callback functions.
I still can't find a good way to resolve this. Can you help?
Shunqian
quoted
Or, do you think it's reasonable to add hooks before/after read in
nvmem/core.c like :
+ before_read(dev, ...);
rc = regmap_raw_read(nvmem->regmap, pos, buf, count);
+ after_read(dev, ...);
quoted
3. In the /sys/bus/nvmem/devices/rockchip-efuse0/, there are files:
/sys/devices/platform/ffb40000.efuse/rockchip-efuse0 # ls
nvmem of_node power subsystem uevent
Do you have a plan to add the nvmem consumers to /sys/ in nvmem
framework?
yes, Am waiting for the framework to be merged, I have plans to add this feature.
quoted
For example, in dts defined the "cpu_leakage":
efuse: efuse@ffb40000 {
compatible = "rockchip,rk3x-efuse";
reg = <0xffb40000 0x20>;
#address-cells = <1>;
#size-cells = <1>;
clocks = <&cru PCLK_EFUSE256>;
clock-names = "pclk_efuse_256";
cpu_leakage: cpu_leakage {
reg = <0x17 0x1>;
};
};
Then nvmem exposes the "cpu_leakage" file in /sys which can be
read/write.