# Re: \[PATCH\]\[v4\] power/fsl: add MDIO dt binding for FMan

- From: Scott Wood \<hidden\>
- Date: 2015-01-30 02:43:40 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2015/01/8103673
- Thread: https://ratatoskr.run/linux-devicetree/2015/01/8103673/t.md

```text
On Thu, 2015-01-29 at 20:38 -0600, Xie Shaohui-B21989 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Friday, January 30, 2015 8:54 AM
> > To: <redacted>
> > Cc: <redacted>; <redacted>; Medve
> > Emilian-EMMEDVE1; Xie Shaohui-B21989
> > Subject: Re: [PATCH][v4] power/fsl: add MDIO dt binding for FMan
> > 
> > On Wed, 2015-01-28 at 19:54 +0800, shh.xie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> > > +- interrupts
> > > +		Usage: required
> > > +		Value type: <prop-encoded-array>
> > > +		Definition: Event interrupt of external MDIO controller.
> > 
> > What if this MDIO controller is not "external"?  Should Usage say
> > "required for external MDIO"?
> [S.H] I thought the definition can tell the interrupt is for external MDIO,
> I can change the Usage to "required for external MDIO" in next version. 
> how about other parts, are they OK?

Yes.  I'll fix it up when applying.

-Scott


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
```
