On Sunday 28 September 2014 12:22:09 Zhangfei Gao wrote:
+
+ i2c0: i2c@b10000 {
+ compatible = "hisilicon,hix5hd2-i2c";
+ reg = <0xb10000 0x1000>;
+ interrupts = <0 38 4>;
+ clocks = <&clock HIX5HD2_I2C0_RST>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
HIX5HD2_I2C0_RST is not defined anywhere, so this will result in the
same build error that has required reverting a lot of patches for the
3.18 merge window.
How do you plan to deal with the dependency in the future?
Arnd
On 09/30/2014 05:02 PM, Arnd Bergmann wrote:
On Sunday 28 September 2014 12:22:09 Zhangfei Gao wrote:
quoted
+
+ i2c0: i2c@b10000 {
+ compatible = "hisilicon,hix5hd2-i2c";
+ reg = <0xb10000 0x1000>;
+ interrupts = <0 38 4>;
+ clocks = <&clock HIX5HD2_I2C0_RST>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
HIX5HD2_I2C0_RST is not defined anywhere, so this will result in the
same build error that has required reverting a lot of patches for the
3.18 merge window.
How do you plan to deal with the dependency in the future?
HIX5HD2_I2C0_RST in clock patch and already been merged through clock
tree in 09/29, should be in 3.18-rc1 (not sure).
When clock patch are combined in the same rc, will send the dts patch.
Sorry for the build issue.
Thanks
On 2014/9/30 17:02, Arnd Bergmann wrote:
On Sunday 28 September 2014 12:22:09 Zhangfei Gao wrote:
quoted
+
+ i2c0: i2c@b10000 {
+ compatible = "hisilicon,hix5hd2-i2c";
+ reg = <0xb10000 0x1000>;
+ interrupts = <0 38 4>;
+ clocks = <&clock HIX5HD2_I2C0_RST>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
Hi Arnd,
HIX5HD2_I2C0_RST is not defined anywhere, so this will result in the
same build error that has required reverting a lot of patches for the
3.18 merge window.
Sorry again for bringing so much troubles to you, Olof and Stephen.
On 9/30, Mike Turquette has already accepted the clock pull request
which includes the HIX5HD2_I2C0_RST definition.
How do you plan to deal with the dependency in the future?
In the future, I will check the dependence firstly about the patches.
When creating pull request tag, I will test it and make sure it works.
And I will also make sure that the order of the pull request is sent correctly.
Best Regards,
Wei
Arnd
.