Re: [PATCHv2 1/5] ASoC: fsl-asrc: Convert to use regmap framework's endianness method.

On Mon, Aug 25, 2014 at 01:44:41AM +0000, Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org wrote:

Hi,

quoted

Subject: Re: [PATCHv2 1/5] ASoC: fsl-asrc: Convert to use regmap framework's
endianness method.

On Tue, Aug 19, 2014 at 12:14:49PM +0800, Xiubo Li wrote:

quoted

Signed-off-by: Xiubo Li <redacted>
---
 sound/soc/fsl/fsl_asrc.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c
index 8221104..3b14531 100644
--- a/sound/soc/fsl/fsl_asrc.c
+++ b/sound/soc/fsl/fsl_asrc.c

@@ -802,10 +802,6 @@ static int fsl_asrc_probe(struct platform_device *pdev)

 	asrc_priv->paddr = res->start;

-	/* Register regmap and let it prepare core clock */
-	if (of_property_read_bool(np, "big-endian"))
-		fsl_asrc_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG;
-

What about the binding document? Could we also update that one
since this 'big-endian' is useless?

Thanks
Nicolin

No, the 'big-endian' is very useful still, deleting this because we are using
The regmap framework's endianness method instead of its own here.

And the binding document, as we have discussed days ago, no need to update here.

Okay.. I think I've missed some topic here.

Thanks,
Nicolin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Hi Nicolin,

quoted

quoted

quoted

diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c
index 8221104..3b14531 100644
--- a/sound/soc/fsl/fsl_asrc.c
+++ b/sound/soc/fsl/fsl_asrc.c

@@ -802,10 +802,6 @@ static int fsl_asrc_probe(struct platform_device

*pdev)

quoted

quoted

quoted

 	asrc_priv->paddr = res->start;

-	/* Register regmap and let it prepare core clock */
-	if (of_property_read_bool(np, "big-endian"))
-		fsl_asrc_regmap_config.val_format_endian =

REGMAP_ENDIAN_BIG;

quoted

quoted

quoted

-

What about the binding document? Could we also update that one
since this 'big-endian' is useless?

Thanks
Nicolin

No, the 'big-endian' is very useful still, deleting this because we are

using

quoted

The regmap framework's endianness method instead of its own here.

And the binding document, as we have discussed days ago, no need to update

here.

Okay.. I think I've missed some topic here.

Please refer to the following patches about this:

regmap: add DT endianness binding support.
regmap: Add the DT binding documentation for endianness
And also two of other patches to fix some bugs of these.

Thanks,

BRs
Xiubo

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html