Re: [PATCH 4/4] ARM: dts: keystone-k2hk: add dsp gpio controllers nodes
From: Alexander Shiyan <hidden>
Date: 2014-08-13 16:06:24
Also in:
linux-gpio
Possibly related (same subject, not in this thread)
- 2014-08-14 · Re: [PATCH 4/4] ARM: dts: keystone-k2hk: add dsp gpio controllers nodes · Grygorii Strashko <grygorii.strashko@ti.com>
- 2014-08-14 · Re: [PATCH 4/4] ARM: dts: keystone-k2hk: add dsp gpio controllers nodes · Grygorii Strashko <grygorii.strashko@ti.com>
- 2014-08-14 · Re: [PATCH 4/4] ARM: dts: keystone-k2hk: add dsp gpio controllers nodes · Alexander Shiyan <hidden>
- 2014-08-14 · Re: [PATCH 4/4] ARM: dts: keystone-k2hk: add dsp gpio controllers nodes · Grygorii Strashko <grygorii.strashko@ti.com>
- 2014-08-14 · Re: [PATCH 4/4] ARM: dts: keystone-k2hk: add dsp gpio controllers nodes · Alexander Shiyan <hidden>
Wed, 13 Aug 2014 19:16:22 +0300 от Grygorii Strashko [off-list ref]:
quoted hunk
Add Keystone 2 DSP GPIO nodes. DSP GPIO banks 0-7 correspond to DSP0-DSP7 Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- arch/arm/boot/dts/k2hk.dtsi | 56 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+)diff --git a/arch/arm/boot/dts/k2hk.dtsi b/arch/arm/boot/dts/k2hk.dtsi index 321ba2f..009e180 100644 --- a/arch/arm/boot/dts/k2hk.dtsi +++ b/arch/arm/boot/dts/k2hk.dtsi@@ -50,5 +50,61 @@ #interrupt-cells = <1>; ti,syscon-dev = <&devctrl 0x2a0>; }; + + dspgpio0: keystone_dsp_gpio@02620240 { + compatible = "ti,keystone-mctrl-gpio"; + gpio-controller; + #gpio-cells = <2>; + gpio,syscon-dev = <&devctrl 0x240>; + }; + + dspgpio1: keystone_dsp_gpio@2620244 { + compatible = "ti,keystone-mctrl-gpio"; + gpio-controller; + #gpio-cells = <2>; + gpio,syscon-dev = <&devctrl 0x244>; + };
...
+ dspgpio7: keystone_dsp_gpio@262025C {
+ compatible = "ti,keystone-mctrl-gpio";
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio,syscon-dev = <&devctrl 0x25c>;
+ };
So, devctrl is a syscon device and this DTS introduce several
identical GPIO descriptions?
On my opinion this should be placed in the gpio-syscon.c,
where you can add support for ti,keystone-dsp0{..7}-gpio.
Such change will avoid parts 2 and 3 of this patch.
static const struct syscon_gpio_data ti_keystone_dsp0_gpio = {
.compatible = "ti,keystone-syscon",
.dat_bit_offset = 0x240 * 8,
...
.set = etc...
};
---
��칻
�&�~�&���+-��ݶ��w��˛���m�^�'
����{ay�
ʇڙ�,j��f���h�����/oSc��ڳ9�u�����&jw��(�階�ݢj"���m�����z�ޖ���f���h���~�m�