[PATCH] scsi: ibmvscsi: ibmvstgt.c: Cleaning up missing null-terminate in conjunction with strncpy
From: Rickard Strandqvist <hidden>
Date: 2014-08-02 23:22:32
Also in:
linux-scsi, lkml
Subsystem:
linux for powerpc (32-bit and 64-bit), scsi subsystem, the rest · Maintainers:
Madhavan Srinivasan, "James E.J. Bottomley", "Martin K. Petersen", Linus Torvalds
Replacing strncpy with strlcpy to avoid strings that lacks null terminate. Signed-off-by: Rickard Strandqvist <redacted> --- drivers/scsi/ibmvscsi/ibmvstgt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvstgt.c b/drivers/scsi/ibmvscsi/ibmvstgt.c
index 56f8a86..5c16d17 100644
--- a/drivers/scsi/ibmvscsi/ibmvstgt.c
+++ b/drivers/scsi/ibmvscsi/ibmvstgt.c@@ -340,7 +340,7 @@ int send_adapter_info(struct iu_entry *iue, memset(info, 0, sizeof(*info)); strcpy(info->srp_version, "16.a"); - strncpy(info->partition_name, partition_name, + strlcpy(info->partition_name, partition_name, sizeof(info->partition_name)); info->partition_number = partition_number; info->mad_version = 1;
@@ -938,7 +938,7 @@ static int get_system_info(void) name = of_get_property(rootdn, "ibm,partition-name", NULL); if (name) - strncpy(partition_name, name, sizeof(partition_name)); + strlcpy(partition_name, name, sizeof(partition_name)); num = of_get_property(rootdn, "ibm,partition-no", NULL); if (num)
--
1.7.10.4