回复：Re: [PATCH v4 1/6] rtc: sun6i: Add sun6i RTC driver

<p dir="ltr">4uHu<br><br></p>
<p dir="ltr">&#21457;&#33258;&#25105;&#30340;&#23567;&#31859;&#25163;&#26426;</p>
Varka Bhadram &lt;varkabhadram@gmail.com&gt;于 2014年7月30日 下午6:37写道：<br type='attribution'><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p/><p dir="ltr">On 07/30/2014 03:03 PM, Chen-Yu Tsai wrote:&#13;<br>
&gt; Hi,&#13;<br>
&gt;&#13;<br>
&gt; On Wed, Jul 30, 2014 at 4:57 PM, Maxime Ripard&#13;<br>
&gt; &lt;<a href="mailto:maxime.ripard@free-electrons.com">maxime.ripard@free-electrons.com</a>&gt; wrote:&#13;<br>
&gt;&gt; Hi Chen-Yu,&#13;<br>
&gt;&gt;&#13;<br>
&gt;&gt; On Mon, Jul 28, 2014 at 04:20:56PM +0800, Chen-Yu Tsai wrote:&#13;<br>
&gt;&gt;&gt; This patch introduces the driver for the RTC in the Allwinner A31 and&#13;<br>
&gt;&gt;&gt; A23 SoCs.&#13;<br>
&gt;&gt;&gt;&#13;<br>
&gt;&gt;&gt; Unlike the RTC found in A10/A20 SoCs, which was part of the timer, the&#13;<br>
&gt;&gt;&gt; RTC in A31/A23 are a separate hardware block, which also contain a few&#13;<br>
&gt;&gt;&gt; controls for the RTC block hardware (a regulator and RTC block GPIO pin&#13;<br>
&gt;&gt;&gt; latches), while also having separate interrupts for the alarms.&#13;<br>
&gt;&gt;&gt;&#13;<br>
&gt;&gt;&gt; The hardware is different enough to make a different driver for it.&#13;<br>
&gt;&gt;&gt;&#13;<br>
&gt;&gt;&gt; Signed-off-by: Chen-Yu Tsai &lt;<a href="mailto:wens@csie.org">wens@csie.org</a>&gt;&#13;<br>
&gt;&gt;&gt; ---&#13;<br>
&gt;&gt;&gt;&nbsp;&nbsp; .../devicetree/bindings/rtc/sun6i-rtc.txt&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp; 17 +&#13;<br>
&gt;&gt;&gt;&nbsp;&nbsp; drivers/rtc/Kconfig&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp;&nbsp; 7 +&#13;<br>
&gt;&gt;&gt;&nbsp;&nbsp; drivers/rtc/Makefile&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp;&nbsp; 1 +&#13;<br>
&gt;&gt;&gt;&nbsp;&nbsp; drivers/rtc/rtc-sun6i.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; | 447 +++++++++++++++++++++&#13;<br>
&gt;&gt;&gt;&nbsp;&nbsp; 4 files changed, 472 insertions(+)&#13;<br>
&gt;&gt;&gt;&nbsp;&nbsp; create mode 100644 Documentation/devicetree/bindings/rtc/sun6i-rtc.txt&#13;<br>
&gt;&gt;&gt;&nbsp;&nbsp; create mode 100644 drivers/rtc/rtc-sun6i.c&#13;<br>
&gt;&gt;&gt;&#13;<br>
&gt;&gt;&gt; diff --git a/Documentation/devicetree/bindings/rtc/sun6i-rtc.txt b/Documentation/devicetree/bindings/rtc/sun6i-rtc.txt&#13;<br>
&gt;&gt;&gt; new file mode 100644&#13;<br>
&gt;&gt;&gt; index 0000000..b7fb7a8&#13;<br>
&gt;&gt;&gt; --- /dev/null&#13;<br>
&gt;&gt;&gt; +++ b/Documentation/devicetree/bindings/rtc/sun6i-rtc.txt&#13;<br>
&gt;&gt;&gt; @@ -0,0 +1,17 @@&#13;<br>
&gt;&gt;&gt; +* sun6i Real Time Clock&#13;<br>
&gt;&gt;&gt; +&#13;<br>
&gt;&gt;&gt; +RTC controller for the Allwinner A31&#13;<br>
&gt;&gt;&gt; +&#13;<br>
&gt;&gt;&gt; +Required properties:&#13;<br>
&gt;&gt;&gt; +- compatible : Should be "allwinner,sun6i-a31-rtc"&#13;<br>
&gt;&gt;&gt; +- reg&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; : physical base address of the controller and length of&#13;<br>
&gt;&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; memory mapped region.&#13;<br>
&gt;&gt;&gt; +- interrupts : IRQ line for the RTC alarm 0.&#13;<br>
&gt;&gt; Even if we're using only one interrupt in the code, the hardware has&#13;<br>
&gt;&gt; two, so it would be great if you could ask for these two in the&#13;<br>
&gt;&gt; bindings.&#13;<br>
&gt; Sure. It's just a minor change here and in the example:&#13;<br>
&gt;&#13;<br>
&gt; - interrupts : IRQ lines for the RTC alarm 0 and alarm 1, in that order.&#13;<br>
&gt;&#13;<br>
&gt; Varka, may I keep your Reviewed-by with the changes?&#13;<br>
&#13;<br>
Reviewed-by: Varka Bhadram &lt;<a href="mailto:varkabhadram@gmail.com">varkabhadram@gmail.com</a>&gt;&#13;<br>
&#13;<br>
-- &#13;<br>
Regards,&#13;<br>
Varka Bhadram.&#13;<br>
&#13;<br>
&#13;<br>
_______________________________________________&#13;<br>
linux-arm-kernel mailing list&#13;<br>
<a href="mailto:linux-arm-kernel@lists.infradead.org">linux-arm-kernel@lists.infradead.org</a>&#13;<br>
<a href="http://lists.infradead.org/mailman/listinfo/linux-arm-kernel">http://lists.infradead.org/mailman/listinfo/linux-arm-kernel</a>&#13;<br>
</p>
</blockquote></div>