[PATCH 1/1] ARM: EXYNOS: Fix compilation warning

of_get_flat_dt_prop return type is now const.
Fixes the following compilation warning introduced by commit 9d0c4dfedd96
("of/fdt: update of_get_flat_dt_prop in prep for libfdt")

arch/arm/mach-exynos/exynos.c:259:6: warning:
assignment discards ‘const’ qualifier from pointer target type [enabled by default]

Signed-off-by: Sachin Kamat <redacted>
Cc: Rob Herring <robh@kernel.org>
---
Based on linux-next (20140505)
---
 arch/arm/mach-exynos/exynos.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
index 77293d39dfc9..f356c67a1fa9 100644
--- a/arch/arm/mach-exynos/exynos.c
+++ b/arch/arm/mach-exynos/exynos.c

@@ -249,7 +249,7 @@ static int __init exynos_fdt_map_chipid(unsigned long node, const char *uname,
 					int depth, void *data)
 {
 	struct map_desc iodesc;
-	__be32 *reg;
+	const __be32 *reg;
 	int len;
 
 	if (!of_flat_dt_is_compatible(node, "samsung,exynos4210-chipid") &&

-- 
1.7.9.5

On 5 May 2014 14:56, Sachin Kamat [off-list ref] wrote:

Ping. This warning is still seen in latest linux-next.

-- 
With warm regards,
Sachin

On 05/21/2014 04:56 PM, Sachin Kamat wrote:

On 5 May 2014 14:56, Sachin Kamat [off-list ref] wrote:

quoted

of_get_flat_dt_prop return type is now const.
Fixes the following compilation warning introduced by commit 9d0c4dfedd96
("of/fdt: update of_get_flat_dt_prop in prep for libfdt")

arch/arm/mach-exynos/exynos.c:259:6: warning:
assignment discards ‘const’ qualifier from pointer target type [enabled by default]

Signed-off-by: Sachin Kamat <redacted>
Cc: Rob Herring <robh@kernel.org>
---

Change looks good.

Reviewed-by: Tushar Behera <redacted>

quoted

Based on linux-next (20140505)
---
 arch/arm/mach-exynos/exynos.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
index 77293d39dfc9..f356c67a1fa9 100644
--- a/arch/arm/mach-exynos/exynos.c
+++ b/arch/arm/mach-exynos/exynos.c

@@ -249,7 +249,7 @@ static int __init exynos_fdt_map_chipid(unsigned long node, const char *uname,
                                        int depth, void *data)
 {
        struct map_desc iodesc;
-       __be32 *reg;
+       const __be32 *reg;
        int len;

        if (!of_flat_dt_is_compatible(node, "samsung,exynos4210-chipid") &&
--

1.7.9.5

Ping. This warning is still seen in latest linux-next.

-- 
Tushar Behera

On Thursday 22 May 2014, Tushar Behera wrote:

On 05/21/2014 04:56 PM, Sachin Kamat wrote:

quoted

On 5 May 2014 14:56, Sachin Kamat [off-list ref] wrote:

quoted

of_get_flat_dt_prop return type is now const.
Fixes the following compilation warning introduced by commit 9d0c4dfedd96
("of/fdt: update of_get_flat_dt_prop in prep for libfdt")

arch/arm/mach-exynos/exynos.c:259:6: warning:
assignment discards ‘const’ qualifier from pointer target type [enabled by default]

Signed-off-by: Sachin Kamat <redacted>
Cc: Rob Herring <robh@kernel.org>
---

Change looks good.

Reviewed-by: Tushar Behera <redacted>

This hasn't shown up in linux-next yet, and hte bug is still there, so I'm applying
it directly to the fixes branch in arm-soc before we get more people sending
the same patch. Thanks!

	Arnd