# Re: \[PATCH 4/6\] regulator: add bcm59056 regulator driver

- From: Mark Brown \<hidden\>
- Date: 2014-02-04 23:22:35 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2014/02/4192477
- Thread: https://ratatoskr.run/linux-devicetree/2014/02/4191685/t.md

```text
On Tue, Feb 04, 2014 at 04:29:14PM -0500, Matt Porter wrote:
> On Tue, Feb 04, 2014 at 05:28:36PM +0000, Mark Brown wrote:

> > > +		/*
> > > +		 * Regulator API handles empty constraints but not NULL
> > > +		 * constraints
> > > +		 */
> > > +		if (!reg_data)
> > > +			continue;

> > It should do...  if not then make it so since that'd mean most drivers
> > are buggy.

> Ahh, I see there is a check for NULL in the core. Will drop.

It was missing in some older kernels (much older now IIRC) - it's
possible that comment was written before this got fixed.
```

## Attachments

- [signature.asc](https://ratatoskr.run/linux-devicetree/2014/02/4192477/attachment/0) (application/pgp-signature, 836 bytes)