# Re: \[PATCH 2/6\] regulator: add bcm59056 pmu DT binding

- From: Mark Brown \<hidden\>
- Date: 2014-02-04 23:21:48 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2014/02/4192476
- Thread: https://ratatoskr.run/linux-devicetree/2014/02/4191685/t.md

```text
On Tue, Feb 04, 2014 at 04:16:38PM -0500, Matt Porter wrote:
> On Tue, Feb 04, 2014 at 05:23:09PM +0000, Mark Brown wrote:

> > Is this really only a regulator - does the chip have no other functions?

> It's your average multi-function device with other functions as you are
> suspecting.  Buried in the the MFD driver comments is me admitting that
> I need to split this into two bindings. The base device, "bcm59056" and
> then "bcm59056-reg". So point noted, I'll updated with the appropriate
> binding for each.

It doesn't need to be two bindings - just move it to the MFD section and
document it there.  The existing binding is totally fine from a
regulator standpoint and should continue to be so as other functions are
added.
```

## Attachments

- [signature.asc](https://ratatoskr.run/linux-devicetree/2014/02/4192476/attachment/0) (application/pgp-signature, 836 bytes)