[PATCH v2 5/6] Documentation: devicetree: sja1000: add reg-io-width binding

Subsystems: can network drivers, open firmware and flattened device tree bindings, the rest

STALE4623d REVIEWED: 6 (6M)

Revision v2 of 3 in this series; 1 review trailer (1 from subsystem maintainers).

3 messages, 2 authors, 2014-02-03 · open the first message on its own page

[PATCH v2 5/6] Documentation: devicetree: sja1000: add reg-io-width binding

From: Florian Vaussard <hidden>
Date: 2014-01-31 10:35:35

Add the reg-io-width property to describe the width of the memory
accesses.

Cc: Grant Likely <redacted>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Pawel Moll <redacted>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Ian Campbell <redacted>
Cc: Kumar Gala <redacted>
Cc: devicetree@vger.kernel.org
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Florian Vaussard <redacted>
---
 Documentation/devicetree/bindings/net/can/sja1000.txt | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/can/sja1000.txt b/Documentation/devicetree/bindings/net/can/sja1000.txt
index f2105a4..b4a6d53 100644
--- a/Documentation/devicetree/bindings/net/can/sja1000.txt
+++ b/Documentation/devicetree/bindings/net/can/sja1000.txt
@@ -12,6 +12,10 @@ Required properties:
 
 Optional properties:
 
+- reg-io-width : Specify the size (in bytes) of the IO accesses that
+	should be performed on the device.  Valid value is 1, 2 or 4.
+	Default to 1 (8 bits).
+
 - nxp,external-clock-frequency : Frequency of the external oscillator
 	clock in Hz. Note that the internal clock frequency used by the
 	SJA1000 is half of that value. If not specified, a default value
-- 
1.8.1.2

Re: [PATCH v2 5/6] Documentation: devicetree: sja1000: add reg-io-width binding

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2014-01-31 12:29:44

On 01/31/2014 11:35 AM, Florian Vaussard wrote:
Add the reg-io-width property to describe the width of the memory
accesses.

Cc: Grant Likely <redacted>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Pawel Moll <redacted>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Ian Campbell <redacted>
Cc: Kumar Gala <redacted>
Cc: devicetree@vger.kernel.org
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Florian Vaussard <redacted>
I think it makes sense to squash into patch 6.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Re: [PATCH v2 5/6] Documentation: devicetree: sja1000: add reg-io-width binding

From: Florian Vaussard <hidden>
Date: 2014-02-03 08:11:45


On 01/31/2014 01:29 PM, Marc Kleine-Budde wrote:
On 01/31/2014 11:35 AM, Florian Vaussard wrote:
quoted
Add the reg-io-width property to describe the width of the memory
accesses.

Cc: Grant Likely <redacted>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Pawel Moll <redacted>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Ian Campbell <redacted>
Cc: Kumar Gala <redacted>
Cc: devicetree@vger.kernel.org
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Florian Vaussard <redacted>
I think it makes sense to squash into patch 6.
According to recent guidelines from the DT maintainers [1], the
documentation part should be a separate patch. I guess it makes sense to
ease the review process for new bindings.

Regards
Florian

[1]
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/submitting-patches.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help