[PATCH] i2c-s3c2410: Fix potential NULL pointer dereference
From: Sachin Kamat <hidden>
Date: 2012-09-18 08:48:48
Also in:
linux-i2c
Subsystem:
arm/samsung s3c, s5p and exynos arm architectures, i2c subsystem, i2c subsystem host drivers, the rest · Maintainers:
Krzysztof Kozlowski, Wolfram Sang, Andi Shyti, Linus Torvalds
of_match_node() returns NULL if a device_node does not have a matching of_match structure. Thus the return value needs to be checked for NULL to avoid NULL pointer dereferencing. Cc: Wolfram Sang <redacted> Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org> Signed-off-by: Sachin Kamat <redacted> --- drivers/i2c/busses/i2c-s3c2410.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 5ae3b02..d906523 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c@@ -123,6 +123,8 @@ static inline unsigned int s3c24xx_get_device_quirks(struct platform_device *pde if (pdev->dev.of_node) { const struct of_device_id *match; match = of_match_node(s3c24xx_i2c_match, pdev->dev.of_node); + if (!match) + return 0; return (unsigned int)match->data; }
--
1.7.4.1