Re: [PATCH v5 01/11] usb: musb: add musb->id to identify core instance

2 messages, 2 authors, 2012-07-25 · open the first message on its own page

Re: [PATCH v5 01/11] usb: musb: add musb->id to identify core instance

From: Felipe Balbi <hidden>
Date: 2012-07-25 12:11:29

hi,

On Wed, Jul 25, 2012 at 05:37:19PM +0530, Ajay Kumar Gupta wrote:
quoted hunk
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 89d1871..f5eb8a7 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
<snip>
quoted hunk
@@ -1889,6 +1921,7 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl)
 	pm_runtime_enable(musb->controller);
 
 	spin_lock_init(&musb->lock);
+	musb->id = pdev->id;
I fail to see where this musb->id would be used. Care to clarify ?

-- 
balbi

RE: [PATCH v5 01/11] usb: musb: add musb->id to identify core instance

From: Gupta, Ajay Kumar <hidden>
Date: 2012-07-25 12:19:32

Hi,
On Wed, Jul 25, 2012 at 05:37:19PM +0530, Ajay Kumar Gupta wrote:
quoted
diff --git a/drivers/usb/musb/musb_core.c
b/drivers/usb/musb/musb_core.c index 89d1871..f5eb8a7 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
<snip>
quoted
@@ -1889,6 +1921,7 @@ musb_init_controller(struct device *dev, int nIrq,
void __iomem *ctrl)
quoted
 	pm_runtime_enable(musb->controller);

 	spin_lock_init(&musb->lock);
+	musb->id = pdev->id;
I fail to see where this musb->id would be used. Care to clarify ?
Sure, It is used in musb_init_debugfs(). Please refer 02/11.

Ajay
--
balbi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help