# Re: \[PATCH\] video: s3c-fb: Add device tree support

- From: Thomas Abraham \<hidden\>
- Date: 2012-01-11 11:11:33 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2012/01/8056935
- Thread: https://ratatoskr.run/linux-fbdev/2012/01/8056907/t.md

```text
Dear Mr. Han,

On 11 January 2012 14:46, Jingoo Han [ref] wrote:
> Hi, Thomas.
>
>> -----Original Message-----
>> From: Thomas Abraham [mailto:<redacted>]
>> Sent: Tuesday, January 10, 2012 5:02 AM
>> To: <redacted>; <redacted>
>> Cc: FlorianSchandinat@gmx.de; <redacted>; <redacted>; linux-arm-
>> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; kgene.kim@samsung.com;
>> jg1.han@samsung.com; patches@linaro.org
>> Subject: [PATCH] video: s3c-fb: Add device tree support
>>
>> Add device tree based discovery support for Samsung's display controller.
>>
>> Cc: Grant Likely <redacted>
>> Cc: Rob Herring <redacted>
>> Signed-off-by: Thomas Abraham <redacted>
>> ---
>>  .../devicetree/bindings/fb/samsung-fb.txt          |  103 ++++++++++
>>  drivers/video/s3c-fb.c                             |  209 +++++++++++++++++++-
>>  2 files changed, 304 insertions(+), 8 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/fb/samsung-fb.txt
>>
>> [...]
>>
>> +- samsung,fimd-bpp: Specifies the bits per pixel. Two values should be
>> +  specified in the following order.
>> +    - max-bpp: maximum required bpp for the overlay.
>> +    - default-bpp: bpp supported by the overlay.
>> [...]
>> +             fimd-overlay0 {
>> +                     samsung,fimd-htiming = <64 16 48 1024>;
>> +                     samsung,fimd-vtiming = <64 16 3 600>;
>> +                     samsung,fimd-bpp = <24 32>;
>> +             };
>> +
>> +             fimd-overlay1 {
>> +                     samsung,fimd-htiming = <64 16 48 200>;
>> +                     samsung,fimd-vtiming = <64 16 3 100>;
>> +                     samsung,fimd-bpp = <16 32>;
>> +             };
>> +     };
> In the above 'samsung-fb.txt', the order is defined as max-bpp and default-bpp.
> However, <24 32> and <16 32> seems to be wrong.
> It should be <32 24> and <32 16>, respectively.
> Max bpp would be 32bpp in s3c-fb.

You are right. I will change the order in the documentation as
default-bpp and then max-bpp. Thanks for correction.

Regards,
Thomas.

>
> Best regards,
> Jingoo Han
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
```