Re: [PATCH] ARM: mmp: remove builtin gpio driver support

2 messages, 2 authors, 2011-07-11 · open the first message on its own page

Re: [PATCH] ARM: mmp: remove builtin gpio driver support

From: Haojian Zhuang <hidden>
Date: 2011-07-11 05:05:51

On Sat, 2011-07-09 at 21:02 -0700, Grant Likely wrote:
On Fri, Jul 08, 2011 at 06:20:18PM +0800, Haojian Zhuang wrote:
quoted
Remove builtin gpio driver support form mmp.

Signed-off-by: Haojian Zhuang <redacted>
Hi Haojian.

I'm not clear what this patch is intending to do.  I understand that
it removes the mmp-specific gpio support, but I looks like don't see the code
that replaces it, which would mean that applying this patch breaks
gpio on mmp platforms.

Am I missing something?
I'm sorry that I shouldn't loop this patch since my new gpio driver
isn't contained in this patch series.

I'm willing to add one operation to select using original gpio driver or
the new one. Since the original gpio driver is shared between ARCH-PXA
and ARCH-mmp. I don't want patch breaking the implementation in
ARCH-PXA.

Thanks
Haojian

Re: [PATCH] ARM: mmp: remove builtin gpio driver support

From: Eric Miao <hidden>
Date: 2011-07-11 11:44:09

On Mon, Jul 11, 2011 at 1:05 PM, Haojian Zhuang
[off-list ref] wrote:
On Sat, 2011-07-09 at 21:02 -0700, Grant Likely wrote:
quoted
On Fri, Jul 08, 2011 at 06:20:18PM +0800, Haojian Zhuang wrote:
quoted
Remove builtin gpio driver support form mmp.

Signed-off-by: Haojian Zhuang <redacted>
Hi Haojian.

I'm not clear what this patch is intending to do.  I understand that
it removes the mmp-specific gpio support, but I looks like don't see the code
that replaces it, which would mean that applying this patch breaks
gpio on mmp platforms.

Am I missing something?
I'm sorry that I shouldn't loop this patch since my new gpio driver
isn't contained in this patch series.

I'm willing to add one operation to select using original gpio driver or
the new one. Since the original gpio driver is shared between ARCH-PXA
and ARCH-mmp. I don't want patch breaking the implementation in
ARCH-PXA.
The built-in version is used for those timing critical situations. In some
best cases, it can be optimized to only one load/store instruction, which
is extremely useful for those bit-banging operations like I2C/SPI emulation
with GPIO.
Thanks
Haojian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help