Reviews by zohar@linux.ibm.com · linux-crypto

All review-attestation trailers (Reviewed-by / Acked-by / Tested-by / Reported-by / Suggested-by / Co-developed-by / Reported-and-tested-by) by this address on the linux-crypto archive.

100 attestations · capped at 100 most-recent. (12 Acked-by, 67 Reviewed-by, 21 Suggested-by)

• STALE341d REVIEWED: 5 (5M) Re: [PATCH] KEYS: encrypted: Use SHA-256 library instead of crypto_shash
  2025-09-07 · Reviewed-by
• STALE516d REVIEWED: 5 (5M) Re: [RFC PATCH v3 02/13] certs: Introduce ability to link to a system key
  2024-12-23 · Reviewed-by
• STALE516d REVIEWED: 5 (5M) Re: [RFC PATCH v3 01/13] certs: Remove CONFIG_INTEGRITY_PLATFORM_KEYRING check
  2024-12-23 · Reviewed-by
• STALE1091d REVIEWED: 5 (5M) Re: [PATCH 9/12] evm: Do not include crypto/algapi.h
  2023-08-24 · Acked-by
• STALE1091d REVIEWED: 5 (5M) Re: [PATCH 10/12] KEYS: encrypted: Do not include crypto/algapi.h
  2023-08-24 · Acked-by
• DORMANTno replies REVIEWED: 5 (5M) Re: [PATCH] crypto: lib - Move mpi into lib/crypto
  2023-08-04 · Reviewed-by
• STALE1187d REVIEWED: 5 (5M) [PATCH v2 2/3] integrity: Enforce digitalSignature usage in the ima and evm keyrings
  2023-05-22 · Suggested-by
• STALE1187d REVIEWED: 5 (5M) [PATCH v2 2/3] integrity: Enforce digitalSignature usage in the ima and evm keyrings
  2023-05-22 · Acked-by
• STALE1187d REVIEWED: 5 (5M) [PATCH v2 1/3] KEYS: DigitalSignature link restriction
  2023-05-22 · Reviewed-by
• STALE1187d REVIEWED: 10 (10M) [PATCH v2 3/3] integrity: Remove EXPERIMENTAL from Kconfig
  2023-05-22 · Reviewed-by
• DORMANTno replies REVIEWED: 5 (5M) Re: [PATCH 3/3] integrity: Remove EXPERIMENTAL from Kconfig
  2023-05-17 · Reviewed-by
• STALE1194d REVIEWED: 5 (5M) Re: [PATCH 2/3] integrity: Enforce digitalSignature usage in the ima and evm keyrings
  2023-05-17 · Acked-by
• STALE1194d REVIEWED: 5 (5M) Re: [PATCH 1/3] KEYS: DigitalSignature link restriction
  2023-05-17 · Reviewed-by
• STALE1194d [PATCH 2/3] integrity: Enforce digitalSignature usage in the ima and evm keyrings
  2023-05-08 · Suggested-by
• STALE1242d REVIEWED: 11 (11M) [PATCH v6 2/6] KEYS: Add missing function documentation
  2023-03-22 · Reviewed-by
• STALE1242d REVIEWED: 11 (11M) [PATCH v6 1/6] KEYS: Create static version of public_key_verify_signature
  2023-03-22 · Reviewed-by
• STALE1242d REVIEWED: 10 (10M) [PATCH v6 4/6] KEYS: X.509: Parse Key Usage
  2023-03-22 · Reviewed-by
• STALE1242d REVIEWED: 5 (5M) [PATCH v6 5/6] KEYS: CA link restriction
  2023-03-22 · Reviewed-by
• STALE1242d REVIEWED: 5 (5M) [PATCH v6 6/6] integrity: machine keyring CA configuration
  2023-03-22 · Acked-by
• STALE1242d REVIEWED: 10 (10M) [PATCH v6 3/6] KEYS: X.509: Parse Basic Constraints for CA
  2023-03-22 · Reviewed-by
• STALE1219d REVIEWED: 5 (5M) Re: [PATCH v5 6/6] integrity: machine keyring CA configuration
  2023-03-13 · Acked-by
• STALE1219d REVIEWED: 5 (5M) [PATCH v5 5/6] KEYS: CA link restriction
  2023-03-02 · Reviewed-by
• STALE1219d REVIEWED: 6 (6M) [PATCH v5 1/6] KEYS: Create static version of public_key_verify_signature
  2023-03-02 · Reviewed-by
• STALE1219d REVIEWED: 10 (10M) [PATCH v5 3/6] KEYS: X.509: Parse Basic Constraints for CA
  2023-03-02 · Reviewed-by
• STALE1219d REVIEWED: 5 (5M) [PATCH v5 4/6] KEYS: X.509: Parse Key Usage
  2023-03-02 · Reviewed-by
• STALE1219d REVIEWED: 11 (11M) [PATCH v5 2/6] KEYS: Add missing function documentation
  2023-03-02 · Reviewed-by
• STALE1285d REVIEWED: 5 (5M) Re: [PATCH v4 5/6] KEYS: CA link restriction
  2023-02-09 · Reviewed-by
• STALE1285d REVIEWED: 5 (5M) Re: [PATCH v4 2/6] KEYS: Add missing function documentation
  2023-02-08 · Reviewed-by
• STALE1285d REVIEWED: 5 (5M) Re: [PATCH v4 4/6] KEYS: X.509: Parse Key Usage
  2023-02-08 · Reviewed-by
• STALE1285d REVIEWED: 5 (5M) Re: [PATCH v4 3/6] KEYS: X.509: Parse Basic Constraints for CA
  2023-02-08 · Reviewed-by
• STALE1285d REVIEWED: 6 (6M) [PATCH v4 1/6] KEYS: Create static version of public_key_verify_signature
  2023-02-07 · Reviewed-by
• STALE1326d REVIEWED: 6 (6M) [PATCH v3 01/10] KEYS: Create static version of public_key_verify_signature
  2022-12-14 · Reviewed-by
• STALE1349d REVIEWED: 5 (5M) [PATCH v2 01/10] KEYS: Create static version of public_key_verify_signature
  2022-12-07 · Reviewed-by
• STALE1383d REVIEWED: 5 (5M) [PATCH 1/7] KEYS: Create static version of public_key_verify_signature
  2022-04-06 · Reviewed-by
• STALE1623d REVIEWED: 5 (5M) [PATCH 1/4] KEYS: Create static version of public_key_verify_signature
  2022-03-01 · Reviewed-by
• STALE1382d REVIEWED: 5 (5M) [PATCH v8 01/17] KEYS: Create static version of public_key_verify_signature
  2021-11-24 · Reviewed-by
• STALE1382d REVIEWED: 5 (5M) [PATCH v8 08/17] integrity: add new keyring handler for mok keys
  2021-11-24 · Reviewed-by
• STALE1382d REVIEWED: 5 (5M) [PATCH v8 04/17] integrity: Do not allow machine keyring updates following init
  2021-11-24 · Reviewed-by
• STALE1382d REVIEWED: 5 (5M) [PATCH v8 02/17] integrity: Fix warning about missing prototypes
  2021-11-24 · Reviewed-by
• STALE1382d REVIEWED: 5 (5M) [PATCH v8 12/17] KEYS: integrity: change link restriction to trust the machine keyring
  2021-11-24 · Reviewed-by
• STALE1382d [PATCH v8 11/17] KEYS: Introduce link restriction for machine keys
  2021-11-24 · Suggested-by
• STALE1382d REVIEWED: 5 (5M) [PATCH v8 09/17] KEYS: Rename get_builtin_and_secondary_restriction
  2021-11-24 · Suggested-by
• STALE1382d REVIEWED: 5 (5M) [PATCH v8 09/17] KEYS: Rename get_builtin_and_secondary_restriction
  2021-11-24 · Reviewed-by
• STALE1382d REVIEWED: 5 (5M) [PATCH v8 03/17] integrity: Introduce a Linux keyring called machine
  2021-11-24 · Reviewed-by
• STALE1734d REVIEWED: 5 (5M) Re: [PATCH v7 12/17] KEYS: integrity: change link restriction to trust the machine keyring
  2021-11-19 · Reviewed-by
• STALE1734d REVIEWED: 5 (5M) Re: [PATCH v7 09/17] KEYS: Rename get_builtin_and_secondary_restriction
  2021-11-19 · Reviewed-by
• STALE1734d REVIEWED: 5 (5M) Re: [PATCH v7 08/17] integrity: add new keyring handler for mok keys
  2021-11-19 · Reviewed-by
• STALE1734d REVIEWED: 5 (5M) Re: [PATCH v7 07/17] integrity: Fix warning about missing prototypes
  2021-11-17 · Reviewed-by
• STALE1734d REVIEWED: 5 (5M) Re: [PATCH v7 03/17] KEYS: Create static version of public_key_verify_signature
  2021-11-17 · Reviewed-by
• STALE1734d REVIEWED: 5 (5M) Re: [PATCH v7 02/17] integrity: Do not allow machine keyring updates following init
  2021-11-17 · Reviewed-by
• STALE1734d REVIEWED: 5 (5M) Re: [PATCH v7 01/17] integrity: Introduce a Linux keyring called machine
  2021-11-17 · Reviewed-by
• STALE1734d [PATCH v7 11/17] KEYS: Introduce link restriction for machine keys
  2021-11-16 · Suggested-by
• STALE1734d [PATCH v7 09/17] KEYS: Rename get_builtin_and_secondary_restriction
  2021-11-16 · Suggested-by
• STALE1796d [PATCH v6 08/13] KEYS: Introduce link restriction for machine keys
  2021-09-14 · Suggested-by
• STALE1796d [PATCH v6 06/13] KEYS: Rename get_builtin_and_secondary_restriction
  2021-09-14 · Suggested-by
• STALE1808d [PATCH v5 07/12] KEYS: Introduce link restriction to include builtin, secondary and machine keys
  2021-09-07 · Suggested-by
• STALE1816d [PATCH v4 07/12] KEYS: Introduce link restriction to include builtin, secondary and mok keys
  2021-08-19 · Suggested-by
• STALE1835d [PATCH v3 09/14] KEYS: Introduce link restriction to include builtin, secondary and mok keys
  2021-08-12 · Suggested-by
• STALE762d REVIEWED: 7 (5M) [PATCH v12 08/10] ima: Support EC keys for signature verification
  2021-03-16 · Acked-by
• STALE762d REVIEWED: 10 (10M) [PATCH v12 10/10] certs: Add support for using elliptic curve keys for signing modules
  2021-03-16 · Reviewed-by
• STALE1991d REVIEWED: 5 (5M) [PATCH v11 10/10] certs: Add support for using elliptic curve keys for signing modules
  2021-03-05 · Reviewed-by
• STALE1991d REVIEWED: 7 (5M) [PATCH v11 08/10] ima: Support EC keys for signature verification
  2021-03-05 · Acked-by
• STALE1995d REVIEWED: 7 (5M) [PATCH v10 7/9] ima: Support EC keys for signature verification
  2021-03-05 · Acked-by
• STALE1995d REVIEWED: 5 (5M) [PATCH v10 9/9] certs: Add support for using elliptic curve keys for signing modules
  2021-03-05 · Reviewed-by
• STALE1994d REVIEWED: 5 (5M) [PATCH v9 9/9] certs: Add support for using elliptic curve keys for signing modules
  2021-02-25 · Reviewed-by
• STALE1994d REVIEWED: 7 (5M) [PATCH v9 4/9] ima: Support EC keys for signature verification
  2021-02-25 · Acked-by
• STALE2006d REVIEWED: 7 (5M) [PATCH v8 4/4] ima: Support EC keys for signature verification
  2021-02-15 · Acked-by
• STALE2018d REVIEWED: 5 (5M) Re: [PATCH v7 4/4] ima: Support EC keys for signature verification
  2021-02-05 · Acked-by
• STALE2158d REVIEWED: 7 (5M) [PATCH v7 10/10] integrity: Asymmetric digsig supports SM2-with-SM3 algorithm
  2020-09-20 · Reviewed-by
• STALE2552d REVIEWED: 6 (5M) Re: [PATCH v12 01/11] MODSIGN: Export module signature definitions
  2019-07-04 · Reviewed-by
• STALE2552d REVIEWED: 6 (5M) Re: [PATCH v12 01/11] MODSIGN: Export module signature definitions
  2019-07-04 · Reviewed-by
• STALE2552d REVIEWED: 5 (5M) [PATCH v12 06/11] ima: Factor xattr_verify() out of ima_appraise_measurement()
  2019-06-28 · Suggested-by
• STALE2552d REVIEWED: 5 (5M) [PATCH v12 06/11] ima: Factor xattr_verify() out of ima_appraise_measurement()
  2019-06-28 · Reviewed-by
• STALE2552d REVIEWED: 5 (5M) [PATCH v12 09/11] ima: Define ima-modsig template
  2019-06-28 · Suggested-by
• STALE2552d REVIEWED: 5 (5M) [PATCH v12 09/11] ima: Define ima-modsig template
  2019-06-28 · Reviewed-by
• STALE2552d [PATCH v12 11/11] ima: Allow template= option for appraise rules as well
  2019-06-28 · Suggested-by
• STALE2552d [PATCH v12 05/11] ima: Add modsig appraise_type option for module-style appended signatures
  2019-06-28 · Suggested-by
• STALE2552d [PATCH v12 10/11] ima: Store the measurement again when appraising a modsig
  2019-06-28 · Suggested-by
• STALE2552d REVIEWED: 5 (5M) [PATCH v12 03/11] PKCS#7: Introduce pkcs7_get_digest()
  2019-06-28 · Reviewed-by
• STALE2552d REVIEWED: 5 (5M) [PATCH v12 01/11] MODSIGN: Export module signature definitions
  2019-06-28 · Reviewed-by
• STALE2552d REVIEWED: 5 (5M) [PATCH v12 02/11] PKCS#7: Refactor verify_pkcs7_signature()
  2019-06-28 · Reviewed-by
• STALE2616d REVIEWED: 5 (5M) [PATCH v11 11/13] ima: Define ima-modsig template
  2019-06-11 · Suggested-by
• STALE2616d REVIEWED: 5 (5M) [PATCH v11 11/13] ima: Define ima-modsig template
  2019-06-11 · Reviewed-by
• STALE2616d [PATCH v11 13/13] ima: Allow template= option for appraise rules as well
  2019-06-11 · Suggested-by
• STALE2616d [PATCH v11 12/13] ima: Store the measurement again when appraising a modsig
  2019-06-11 · Suggested-by
• STALE2616d REVIEWED: 5 (5M) [PATCH v11 08/13] ima: Factor xattr_verify() out of ima_appraise_measurement()
  2019-06-11 · Suggested-by
• STALE2616d REVIEWED: 5 (5M) [PATCH v11 08/13] ima: Factor xattr_verify() out of ima_appraise_measurement()
  2019-06-11 · Reviewed-by
• STALE2616d [PATCH v11 07/13] ima: Add modsig appraise_type option for module-style appended signatures
  2019-06-11 · Suggested-by
• STALE2616d REVIEWED: 5 (5M) [PATCH v11 06/13] ima: Use designated initializers for struct ima_event_data
  2019-06-11 · Reviewed-by
• STALE2616d REVIEWED: 5 (5M) [PATCH v11 04/13] integrity: Introduce struct evm_xattr
  2019-06-11 · Reviewed-by
• STALE2616d REVIEWED: 5 (5M) [PATCH v11 03/13] PKCS#7: Introduce pkcs7_get_digest()
  2019-06-11 · Reviewed-by
• STALE2616d REVIEWED: 5 (5M) [PATCH v11 02/13] PKCS#7: Refactor verify_pkcs7_signature()
  2019-06-11 · Reviewed-by
• STALE2616d REVIEWED: 5 (5M) [PATCH v11 01/13] MODSIGN: Export module signature definitions
  2019-06-11 · Reviewed-by
• STALE2643d REVIEWED: 5 (5M) Re: [PATCH v10 11/12] ima: Define ima-modsig template
  2019-05-09 · Reviewed-by
• STALE2643d REVIEWED: 5 (5M) Re: [PATCH v10 08/12] ima: Factor xattr_verify() out of ima_appraise_measurement()
  2019-05-09 · Reviewed-by
• STALE2643d REVIEWED: 5 (5M) Re: [PATCH v10 06/12] ima: Use designated initializers for struct ima_event_data
  2019-05-09 · Reviewed-by
• STALE2643d REVIEWED: 5 (5M) Re: [PATCH v10 02/12] PKCS#7: Refactor verify_pkcs7_signature()
  2019-05-09 · Reviewed-by
• STALE2643d REVIEWED: 5 (5M) Re: [PATCH v10 03/12] PKCS#7: Introduce pkcs7_get_digest()
  2019-05-09 · Reviewed-by
• STALE2643d REVIEWED: 5 (5M) Re: [PATCH v10 01/12] MODSIGN: Export module signature definitions
  2019-05-09 · Reviewed-by
• STALE2595d REVIEWED: 5 (5M) [PATCH] X.509: Add messages for obsolete OIDs
  2019-05-02 · Reviewed-by