# Re: \[PATCH v3 4/5\] amba: Make the remove callback return void

- From: Greg Kroah-Hartman \<gregkh@linuxfoundation.org\>
- Date: 2021-01-27 12:06:54 
- List: linux-crypto
- Page: https://ratatoskr.run/linux-crypto/2021/01/6249410
- Thread: https://ratatoskr.run/linux-crypto/2021/01/6248565/t.md

```text
On Tue, Jan 26, 2021 at 05:58:34PM +0100, Uwe Kleine-König wrote:
> All amba drivers return 0 in their remove callback. Together with the
> driver core ignoring the return value anyhow, it doesn't make sense to
> return a value here.
> 
> Change the remove prototype to return void, which makes it explicit that
> returning an error value doesn't work as expected. This simplifies changing
> the core remove callback to return void, too.
> 
> Reviewed-by: Ulf Hansson <redacted>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> # for drivers/memory
> Acked-by: Mark Brown <broonie@kernel.org>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Acked-by: Linus Walleij <redacted>
> Signed-off-by: Uwe Kleine-König <redacted>

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```