# Re: \[PATCH v3 4/5\] amba: Make the remove callback return void

- From: Russell King - ARM Linux admin \<linux@armlinux.org.uk\>
- Date: 2021-01-27 01:51:48 
- List: linux-crypto
- Page: https://ratatoskr.run/linux-crypto/2021/01/6248645
- Thread: https://ratatoskr.run/linux-rtc/2021/01/6248565/t.md

```text
On Tue, Jan 26, 2021 at 06:56:52PM +0100, Uwe Kleine-König wrote:
> I'm surprised to see that the remove callback introduced in 2952ecf5df33
> ("coresight: etm4x: Refactor probing routine") has an __exit annotation.

In general, remove callbacks should not have an __exit annotation.
__exit _can_ be discarded at link time for built-in stuff.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
```