[PATCH] crypto: glue_helper - Delete some dead code

Subsystems: the rest, x86 architecture (32-bit and 64-bit)

STALE3334d

2 messages, 2 authors, 2017-06-19 · open the first message on its own page

[PATCH] crypto: glue_helper - Delete some dead code

From: Dan Carpenter <hidden>
Date: 2017-05-10 05:53:07

We checked (nbytes < bsize) inside the loops so it's not possible to hit
the "goto done;" here.  This code is cut and paste from other slightly
different loops where we don't have the check inside the loop.

Signed-off-by: Dan Carpenter <redacted>
diff --git a/arch/x86/crypto/glue_helper.c b/arch/x86/crypto/glue_helper.c
index 24ac9fad832d..d61e57960fe0 100644
--- a/arch/x86/crypto/glue_helper.c
+++ b/arch/x86/crypto/glue_helper.c
@@ -176,9 +176,6 @@ __glue_cbc_decrypt_128bit(const struct common_glue_ctx *gctx,
 				src -= 1;
 				dst -= 1;
 			} while (nbytes >= func_bytes);
-
-			if (nbytes < bsize)
-				goto done;
 		}
 	}
 

Re: [PATCH] crypto: glue_helper - Delete some dead code

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2017-06-19 06:40:26

On Wed, May 10, 2017 at 08:52:26AM +0300, Dan Carpenter wrote:
We checked (nbytes < bsize) inside the loops so it's not possible to hit
the "goto done;" here.  This code is cut and paste from other slightly
different loops where we don't have the check inside the loop.

Signed-off-by: Dan Carpenter <redacted>
Patch applied.  Thanks.
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help