[bug report] crypto: cavium - Add the Virtual Function driver for CPT

From: Dan Carpenter <hidden>
Date: 2017-02-16 20:18:59

Hello George Cherian,

This is a semi-automatic email about new static checker warnings.

The patch c694b233295b: "crypto: cavium - Add the Virtual Function
driver for CPT" from Feb 7, 2017, leads to the following Smatch
complaint:

drivers/crypto/cavium/cpt/cptvf_main.c:899 cptvf_remove()
	 error: we previously assumed 'cptvf' could be null (see line 895)

drivers/crypto/cavium/cpt/cptvf_main.c
   894	
   895		if (!cptvf)
                     ^^^^^
Check for NULL.

   896			dev_err(&pdev->dev, "Invalid CPT-VF device\n");
   897	
   898		/* Convey DOWN to PF */
   899		if (cptvf_send_vf_down(cptvf)) {
                                       ^^^^^
Oops inside function.

   900			dev_err(&pdev->dev, "PF not responding to DOWN msg");
   901		} else {

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help