DORMANTno replies

[PATCH] crypto: rsa - Add Makefile dependencies to fix parallel builds

From: David Michael <hidden>
Date: 2016-11-29 19:15:15
Subsystem: crypto api, the rest · Maintainers: Herbert Xu, "David S. Miller", Linus Torvalds

Both asn1 headers are included by rsa_helper.c, so rsa_helper.o
should explicitly depend on them.

Signed-off-by: David Michael <redacted>
---

Hi,

Our automated CI builds randomly fail with the following:

../source/crypto/rsa_helper.c:19:29: fatal error: rsaprivkey-asn1.h: No such file or directory
../source/scripts/Makefile.build:289: recipe for target 'crypto/rsa_helper.o' failed

I've added the following line and run a dozen or so builds, and they
have not failed since.  Can this patch be applied?

Thanks.

David

 crypto/Makefile | 1 +
 1 file changed, 1 insertion(+)
diff --git a/crypto/Makefile b/crypto/Makefile
index 99cc64a..bd6a029 100644
--- a/crypto/Makefile
+++ b/crypto/Makefile
@@ -40,6 +40,7 @@ obj-$(CONFIG_CRYPTO_ECDH) += ecdh_generic.o
 
 $(obj)/rsapubkey-asn1.o: $(obj)/rsapubkey-asn1.c $(obj)/rsapubkey-asn1.h
 $(obj)/rsaprivkey-asn1.o: $(obj)/rsaprivkey-asn1.c $(obj)/rsaprivkey-asn1.h
+$(obj)/rsa_helper.o: $(obj)/rsapubkey-asn1.h $(obj)/rsaprivkey-asn1.h
 clean-files += rsapubkey-asn1.c rsapubkey-asn1.h
 clean-files += rsaprivkey-asn1.c rsaprivkey-asn1.h
 
-- 
2.7.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help