[cryptodev:master 53/61] fs/nfsd/nfs4recover.c:147:1: warning: 'nfs4_make_rec_clidname' uses dynamic stack allocation
From: kbuild test robot <hidden>
Date: 2016-01-27 15:03:50
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 2f313e029020f1fa5f58f38f48ff6988d67fc3c1 commit: 1edb82d2021c7bae96509c03c4c5ef789f1e09a3 [53/61] nfsd: Use shash config: s390-allyesconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 1edb82d2021c7bae96509c03c4c5ef789f1e09a3 # save the attached .config to linux build tree make.cross ARCH=s390 All warnings (new ones prefixed by >>): fs/nfsd/nfs4recover.c: In function 'nfs4_make_rec_clidname':
quoted
fs/nfsd/nfs4recover.c:147:1: warning: 'nfs4_make_rec_clidname' uses dynamic stack allocation
}
^
vim +/nfs4_make_rec_clidname +147 fs/nfsd/nfs4recover.c
1edb82d2 Herbert Xu 2016-01-24 131 status = crypto_shash_digest(desc, clname->data, clname->len,
1edb82d2 Herbert Xu 2016-01-24 132 cksum.data);
1edb82d2 Herbert Xu 2016-01-24 133 shash_desc_zero(desc);
1edb82d2 Herbert Xu 2016-01-24 134 }
a55370a3 NeilBrown 2005-06-23 135
2216d449 Jeff Layton 2012-11-12 136 if (status)
35058687 Herbert Xu 2006-08-24 137 goto out;
a55370a3 NeilBrown 2005-06-23 138
a55370a3 NeilBrown 2005-06-23 139 md5_to_hex(dname, cksum.data);
a55370a3 NeilBrown 2005-06-23 140
2216d449 Jeff Layton 2012-11-12 141 status = 0;
a55370a3 NeilBrown 2005-06-23 142 out:
2bd9e7b6 Krishna Kumar 2008-10-20 143 kfree(cksum.data);
1edb82d2 Herbert Xu 2016-01-24 144 crypto_free_shash(tfm);
35058687 Herbert Xu 2006-08-24 145 out_no_tfm:
a55370a3 NeilBrown 2005-06-23 146 return status;
a55370a3 NeilBrown 2005-06-23 @147 }
190e4fbf NeilBrown 2005-06-23 148
2216d449 Jeff Layton 2012-11-12 149 /*
2216d449 Jeff Layton 2012-11-12 150 * If we had an error generating the recdir name for the legacy tracker
2216d449 Jeff Layton 2012-11-12 151 * then warn the admin. If the error doesn't appear to be transient,
2216d449 Jeff Layton 2012-11-12 152 * then disable recovery tracking.
2216d449 Jeff Layton 2012-11-12 153 */
2216d449 Jeff Layton 2012-11-12 154 static void
7255e716 Jeff Layton 2013-05-09 155 legacy_recdir_name_error(struct nfs4_client *clp, int error)
:::::: The code at line 147 was first introduced by commit
:::::: a55370a3c0106106a975c5a09cee800611d0cf50 [PATCH] knfsd: nfsd4: reboot hash
:::::: TO: NeilBrown [off-list ref]
:::::: CC: Linus Torvalds [off-list ref]
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation Attachments
- .config.gz [application/octet-stream] 40104 bytes