[cryptodev:master 50/61] drivers/nfc/s3fwrn5/firmware.c:501:1: warning: 's3fwrn5_fw_download' uses dynamic stack allocation
From: kbuild test robot <hidden>
Date: 2016-01-27 14:56:48
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 2f313e029020f1fa5f58f38f48ff6988d67fc3c1 commit: 4a31340b36302d46207c6bb54d103d9fb568e916 [50/61] nfc: s3fwrn5: Use shash config: s390-allyesconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 4a31340b36302d46207c6bb54d103d9fb568e916 # save the attached .config to linux build tree make.cross ARCH=s390 All warnings (new ones prefixed by >>): drivers/nfc/s3fwrn5/firmware.c: In function 's3fwrn5_fw_download':
quoted
drivers/nfc/s3fwrn5/firmware.c:501:1: warning: 's3fwrn5_fw_download' uses dynamic stack allocation
}
^
vim +/s3fwrn5_fw_download +501 drivers/nfc/s3fwrn5/firmware.c
c04c674f Robert Baldyga 2015-08-20 485 goto out;
c04c674f Robert Baldyga 2015-08-20 486 }
c04c674f Robert Baldyga 2015-08-20 487 }
c04c674f Robert Baldyga 2015-08-20 488
c04c674f Robert Baldyga 2015-08-20 489 ret = s3fwrn5_fw_complete_update_mode(fw_info);
c04c674f Robert Baldyga 2015-08-20 490 if (ret < 0) {
c04c674f Robert Baldyga 2015-08-20 491 dev_err(&fw_info->ndev->nfc_dev->dev,
c04c674f Robert Baldyga 2015-08-20 492 "Unable to complete update mode\n");
c04c674f Robert Baldyga 2015-08-20 493 goto out;
c04c674f Robert Baldyga 2015-08-20 494 }
c04c674f Robert Baldyga 2015-08-20 495
c04c674f Robert Baldyga 2015-08-20 496 dev_info(&fw_info->ndev->nfc_dev->dev,
c04c674f Robert Baldyga 2015-08-20 497 "Firmware update: success\n");
c04c674f Robert Baldyga 2015-08-20 498
c04c674f Robert Baldyga 2015-08-20 499 out:
c04c674f Robert Baldyga 2015-08-20 500 return ret;
c04c674f Robert Baldyga 2015-08-20 @501 }
c04c674f Robert Baldyga 2015-08-20 502
c04c674f Robert Baldyga 2015-08-20 503 void s3fwrn5_fw_init(struct s3fwrn5_fw_info *fw_info, const char *fw_name)
c04c674f Robert Baldyga 2015-08-20 504 {
c04c674f Robert Baldyga 2015-08-20 505 fw_info->parity = 0x00;
c04c674f Robert Baldyga 2015-08-20 506 fw_info->rsp = NULL;
c04c674f Robert Baldyga 2015-08-20 507 fw_info->fw.fw = NULL;
c04c674f Robert Baldyga 2015-08-20 508 strcpy(fw_info->fw_name, fw_name);
c04c674f Robert Baldyga 2015-08-20 509 init_completion(&fw_info->completion);
:::::: The code at line 501 was first introduced by commit
:::::: c04c674fadeb4a8e6522fc838d4620f7cfd4c621 nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC Chip
:::::: TO: Robert Baldyga [off-list ref]
:::::: CC: Samuel Ortiz [off-list ref]
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation Attachments
- .config.gz [application/octet-stream] 40104 bytes