Reviews by heiko@sntech.de · linux-clk

All review-attestation trailers (Reviewed-by / Acked-by / Tested-by / Reported-by / Suggested-by / Co-developed-by / Reported-and-tested-by) by this address on the linux-clk archive.

100 attestations · capped at 100 most-recent. (13 Acked-by, 64 Reviewed-by, 2 Suggested-by, 21 Tested-by)

• DORMANTno replies REVIEWED: 3 (3M) Re: [PATCH 2/2] phy: rockchip: Make sure clk_init_data is fully initialized
  2026-08-27 · Reviewed-by
• HOTtoday REVIEWED: 3 (3M) Re: [PATCH 28/45] clk: rockchip: Make sure clk_init_data is fully initialized
  2026-08-24 · Reviewed-by
• DORMANTno replies REVIEWED: 3 (3M) Re: [PATCH] clk: rk808: fix OF node reference imbalance
  2026-05-05 · Reviewed-by
• STALE119d REVIEWED: 3 (3M) Re: [PATCH] clk: rk808: fix OF node reference imbalance
  2026-04-27 · Reviewed-by
• STALE69d [PATCH v4 3/5] clk: rockchip: add helper to register auxiliary GRFs
  2026-04-19 · Suggested-by
• STALE236d REVIEWED: 4 (3M) [PATCH v3 8/9] phy: rockchip: phy-rockchip-samsung-hdptx: convert from round_rate() to determine_rate()
  2025-12-11 · Reviewed-by
• STALE236d REVIEWED: 3 (3M) [PATCH v3 7/9] phy: rockchip: phy-rockchip-inno-hdmi: convert from round_rate() to determine_rate()
  2025-12-11 · Reviewed-by
• STALE288d REVIEWED: 4 (3M) [PATCH v2 RESEND 8/9] phy: rockchip: phy-rockchip-samsung-hdptx: convert from round_rate() to determine_rate()
  2025-11-06 · Reviewed-by
• STALE288d REVIEWED: 3 (3M) [PATCH v2 RESEND 7/9] phy: rockchip: phy-rockchip-inno-hdmi: convert from round_rate() to determine_rate()
  2025-11-06 · Reviewed-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 19/20] clk: sp7021: switch to FIELD_PREP_WM16 macro
  2025-08-27 · Reviewed-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 20/20] phy: rockchip-pcie: switch to FIELD_PREP_WM16 macro
  2025-08-27 · Reviewed-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 18/20] PM / devfreq: rockchip-dfi: switch to FIELD_PREP_WM16 macro
  2025-08-27 · Reviewed-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 17/20] PCI: dw-rockchip: Switch to FIELD_PREP_WM16 macro
  2025-08-27 · Reviewed-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 16/20] PCI: rockchip: Switch to FIELD_PREP_WM16* macros
  2025-08-27 · Reviewed-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 15/20] net: stmmac: dwmac-rk: switch to FIELD_PREP_WM16 macro
  2025-08-27 · Acked-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 14/20] ASoC: rockchip: i2s-tdm: switch to FIELD_PREP_WM16_CONST macro
  2025-08-27 · Reviewed-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 13/20] drm/rockchip: dw_hdmi: switch to FIELD_PREP_WM16* macros
  2025-08-27 · Reviewed-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 12/20] phy: rockchip-usb: switch to FIELD_PREP_WM16 macro
  2025-08-27 · Reviewed-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 11/20] drm/rockchip: inno-hdmi: switch to FIELD_PREP_WM16 macro
  2025-08-27 · Reviewed-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 10/20] drm/rockchip: dw_hdmi_qp: switch to FIELD_PREP_WM16 macro
  2025-08-27 · Reviewed-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 09/20] phy: rockchip-samsung-dcphy: switch to FIELD_PREP_WM16 macro
  2025-08-27 · Reviewed-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 08/20] drm/rockchip: vop2: switch to FIELD_PREP_WM16 macro
  2025-08-27 · Reviewed-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 07/20] drm/rockchip: dsi: switch to FIELD_PREP_WM16* macros
  2025-08-27 · Reviewed-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 06/20] phy: rockchip-emmc: switch to FIELD_PREP_WM16 macro
  2025-08-27 · Acked-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 05/20] drm/rockchip: lvds: switch to FIELD_PREP_WM16 macro
  2025-08-27 · Reviewed-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 04/20] media: synopsys: hdmirx: replace macros with bitfield variants
  2025-08-27 · Acked-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 03/20] soc: rockchip: grf: switch to FIELD_PREP_WM16_CONST macro
  2025-08-27 · Reviewed-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 02/20] mmc: dw_mmc-rockchip: switch to FIELD_PREP_WM16 macro
  2025-08-27 · Reviewed-by
• STALE336d REVIEWED: 3 (3M) Re: [PATCH v3 01/20] bitmap: introduce hardware-specific bitfield operations
  2025-08-27 · Acked-by
• STALE692d REVIEWED: 3 (3M) Re: [PATCH] clk: rockchip: fix finding of maximum clock ID
  2024-09-14 · Reviewed-by
• STALE812d REVIEWED: 3 (3M) Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string()
  2024-06-04 · Acked-by
• STALE906d REVIEWED: 3 (3M) Re: [PATCH v1 1/1] clk: fractional-divider: Move mask calculations out of lock
  2024-03-04 · Reviewed-by
• STALE1245d REVIEWED: 3 (3M) Re: [PATCH v2 4/4] clk: Remove mmask and nmask fields in struct clk_fractional_divider
  2023-04-02 · Reviewed-by
• STALE1245d REVIEWED: 3 (3M) Re: [PATCH v2 3/4] clk: rockchip: Remove values for mmask and nmask in struct clk_fractional_divider
  2023-04-02 · Reviewed-by
• STALE1245d REVIEWED: 3 (3M) Re: [PATCH v2 1/4] clk: Compute masks for fractional_divider clk when needed.
  2023-04-02 · Reviewed-by
• STALE1245d REVIEWED: 3 (3M) Re: [PATCH v2 1/4] clk: Compute masks for fractional_divider clk when needed.
  2023-04-02 · Reviewed-by
• STALE1379d REVIEWED: 3 (3M) Re: [PATCH] clk: Remove a useless include
  2022-11-13 · Acked-by
• STALE1554d REVIEWED: 3 (3M) [PATCHv2 12/21] pinctrl/rockchip: add error handling for pull/drive register getters
  2022-05-04 · Reviewed-by
• STALE1582d REVIEWED: 3 (3M) Re: [PATCHv1 12/19] pinctrl/rockchip: add error handling for pull/drive register getters
  2022-04-22 · Reviewed-by
• STALE1807d LANDED: 6 (6M) [PATCH v2] clk: rockchip: use module_platform_driver_probe
  2021-09-04 · Tested-by
• STALE1807d LANDED: 6 (6M) [PATCH v2] clk: rockchip: use module_platform_driver_probe
  2021-09-04 · Reviewed-by
• STALE1823d REVIEWED: 6 (6M) Re: [PATCH] clk: rockchip: use module_platform_driver_probe
  2021-09-03 · Tested-by
• STALE1823d REVIEWED: 6 (6M) Re: [PATCH] clk: rockchip: use module_platform_driver_probe
  2021-09-03 · Reviewed-by
• STALE1820d LANDED: 6 (6M) [PATCH v4 1/4] clk: fractional-divider: Export approximation algorithm to the CCF users
  2021-08-12 · Tested-by
• STALE1820d LANDED: 6 (6M) [PATCH v4 1/4] clk: fractional-divider: Export approximation algorithm to the CCF users
  2021-08-12 · Acked-by
• STALE1840d LANDED [PATCH v2 2/8] clk: rockchip: fix clk-pll rk356x early pll init
  2021-07-28 · Suggested-by
• DORMANTno replies REVIEWED: 6 (6M) [PATCH v3 1/4] clk: fractional-divider: Export approximation algorithm to the CCF users
  2021-07-22 · Tested-by
• DORMANTno replies REVIEWED: 6 (6M) [PATCH v3 1/4] clk: fractional-divider: Export approximation algorithm to the CCF users
  2021-07-22 · Acked-by
• STALE1867d REVIEWED: 6 (6M) Re: [PATCH v2 1/3] clk: fractional-divider: Export approximation algo to the CCF users
  2021-07-17 · Tested-by
• STALE1867d REVIEWED: 6 (6M) Re: [PATCH v2 1/3] clk: fractional-divider: Export approximation algo to the CCF users
  2021-07-17 · Acked-by
• DORMANTno replies REVIEWED: 3 (3M) Re: [PATCH] clk: rockchip: Initialize hw to error to avoid undefined behavior
  2020-09-24 · Reviewed-by
• STALE2170d LANDED: 4 (3M) [PATCH v4 1/6] clk: rockchip: Use clk_hw_register_composite instead of clk_register_composite calls
  2020-09-14 · Reviewed-by
• STALE2183d REVIEWED: 3 (3M) Re: [PATCH v3 1/6] clk: rockchip: Use clk_hw_register_composite instead of clk_register_composite calls
  2020-09-06 · Reviewed-by
• STALE2205d REVIEWED: 3 (3M) Re: [PATCH] clk: rockchip: Fix initialization of mux_pll_src_4plls_p
  2020-08-12 · Reviewed-by
• STALE2444d REVIEWED: 3 (3M) Re: [PATCH 2/3] clk: let init callback return an error code
  2019-09-29 · Acked-by
• STALE2666d REVIEWED: 3 (3M) Re: [PATCH] clk: Remove io.h from clk-provider.h
  2019-05-15 · Acked-by
• STALE2673d REVIEWED: 3 (3M) Re: [PATCH] clk: rockchip: Don't yell about bad mmc phases when getting
  2019-05-03 · Reviewed-by
• STALE2715d REVIEWED: 3 (3M) [PATCH AUTOSEL 4.19 070/192] clk: fractional-divider: check parent rate only if flag is set
  2019-03-27 · Reviewed-by
• STALE2715d REVIEWED: 3 (3M) [PATCH AUTOSEL 4.14 048/123] clk: fractional-divider: check parent rate only if flag is set
  2019-03-27 · Reviewed-by
• STALE2707d REVIEWED: 3 (3M) [PATCH AUTOSEL 5.0 104/262] clk: fractional-divider: check parent rate only if flag is set
  2019-03-27 · Reviewed-by
• STALE2749d REVIEWED: 3 (3M) Re: [PATCH v2] clk: fractional-divider: check parent rate only if flag is set
  2019-02-10 · Reviewed-by
• STALE3044d REVIEWED: 3 (3M) [PATCH v3 1/5] clk: Extract OF clock helpers in <linux/of_clk.h>
  2018-04-18 · Reviewed-by
• STALE3044d REVIEWED: 3 (3M) [PATCH v3 3/5] soc: rockchip: power-domain: Use of_clk_get_parent_count() instead of open coding
  2018-04-18 · Reviewed-by
• STALE3050d REVIEWED: 3 (3M) Re: [PATCH v2 3/5] soc: rockchip: power-domain: Use of_clk_get_parent_count() instead of open coding
  2018-04-10 · Reviewed-by
• STALE3050d REVIEWED: 3 (3M) Re: [PATCH v2 1/5] clk: Extract OF clock helpers in <linux/of_clk.h>
  2018-04-10 · Reviewed-by
• STALE3116d REVIEWED: 6 (6M) Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata
  2018-02-16 · Tested-by
• STALE3116d REVIEWED: 6 (6M) Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata
  2018-02-16 · Acked-by
• STALE3095d REVIEWED: 3 (3M) Re: [PATCH v2 4/8] clk: migrate the count of orphaned clocks at init
  2018-02-15 · Tested-by
• STALE3313d REVIEWED: 3 (3M) Re: [PATCH 03/14] pinctrl: rockchip: add input schmitt support for rv1108
  2017-07-31 · Reviewed-by
• STALE3028d REVIEWED: 3 (3M) Re: [PATCH 000/102] Convert drivers to explicit reset API
  2017-07-20 · Acked-by
• STALE3458d REVIEWED: 6 (6M) [RFC 1/2] clk: dt: binding for basic divider clock
  2017-03-14 · Tested-by
• STALE3458d REVIEWED: 6 (6M) [RFC 1/2] clk: dt: binding for basic divider clock
  2017-03-14 · Reviewed-by
• STALE3459d REVIEWED: 3 (3M) Re: [PATCH] serial: 8250_dw: Fix breakage when HAVE_CLK=n
  2017-03-05 · Reviewed-by
• STALE3757d REVIEWED: 6 (6M) Re: [PATCH] clk: fix critical clock locking
  2016-05-17 · Reviewed-by
• STALE3757d REVIEWED: 6 (6M) Re: [PATCH] clk: fix critical clock locking
  2016-05-17 · Tested-by
• STALE3759d REVIEWED: 3 (3M) Re: [PATCH 1/2] Revert "clk: rockchip: reset init state before mmc card initialization"
  2016-05-12 · Reviewed-by
• STALE3791d REVIEWED: 3 (3M) [PATCH v2] clk: Add clk_composite_set_rate_and_parent
  2016-04-12 · Reviewed-by
• STALE3791d REVIEWED: 3 (3M) Re: [PATCH v1] clk: Add clk_composite_set_rate_and_parent
  2016-04-12 · Reviewed-by
• STALE3792d REVIEWED: 3 (3M) [PATCH v5 23/46] pwm: rockchip: add support for atomic update
  2016-03-30 · Tested-by
• STALE3792d REVIEWED: 11 (11M) [PATCH v5 29/46] regulator: pwm: properly initialize the ->state field
  2016-03-30 · Tested-by
• STALE3808d REVIEWED: 3 (3M) Re: [PATCH 3/7] clk: rockchip: Make reset_control_ops const
  2016-02-25 · Reviewed-by
• STALE3927d REVIEWED: 3 (3M) [PATCH v4] clk: rockchip: switch PLLs to slow mode before reboot for rk3288
  2015-11-27 · Reviewed-by
• STALE3821d REVIEWED: 8 (7M) [PATCH v4 07/24] pwm: use pwm_get/set_default_xxx() helpers where appropriate
  2015-11-16 · Tested-by
• STALE3821d REVIEWED: 3 (3M) [PATCH v4 06/24] pwm: introduce default period and polarity concepts
  2015-11-16 · Tested-by
• STALE3821d REVIEWED: 3 (3M) [PATCH v4 09/24] regulator: pwm: use pwm_get/set_default_xxx() helpers where appropriate
  2015-11-16 · Tested-by
• STALE3821d REVIEWED: 3 (3M) [PATCH v4 16/24] pwm: move the enabled/disabled info to pwm_state struct
  2015-11-16 · Tested-by
• STALE3821d REVIEWED: 3 (3M) [PATCH v4 18/24] pwm: declare a default PWM state
  2015-11-16 · Tested-by
• STALE3821d REVIEWED: 3 (3M) [PATCH v4 19/24] pwm: add the PWM initial state retrieval infra
  2015-11-16 · Tested-by
• STALE3821d REVIEWED: 3 (3M) [PATCH v4 22/24] pwm: rockchip: add initial state retrieval
  2015-11-16 · Tested-by
• STALE3821d REVIEWED: 11 (11M) [PATCH v4 24/24] regulator: pwm: properly initialize the ->state field
  2015-11-16 · Tested-by
• STALE3821d REVIEWED: 3 (3M) [PATCH v4 23/24] pwm: rockchip: add support for atomic update
  2015-11-16 · Tested-by
• STALE3821d REVIEWED: 3 (3M) [PATCH v4 20/24] pwm: add the core infrastructure to allow atomic update
  2015-11-16 · Tested-by
• STALE3932d REVIEWED: 3 (3M) [PATCH v3] clk: rockchip: switch PLLs to slow mode before reboot for rk3288
  2015-11-11 · Reviewed-by
• DORMANTno replies REVIEWED: 3 (3M) Re: [PATCH v2] clk: rockchip: switch PLLs to slow mode before reboot for rk3288
  2015-11-11 · Reviewed-by
• STALE3935d REVIEWED: 3 (3M) [PATCH v7 4/6] clk: rockchip: add clock controller for rk3036
  2015-11-05 · Reviewed-by
• STALE3935d REVIEWED: 3 (3M) [PATCH v7 3/6] clk: rockchip: add new pll-type for rk3036 and similar socs
  2015-11-05 · Reviewed-by
• STALE3935d REVIEWED: 3 (3M) [PATCH v7 0/6] Build and support rk3036 SoC platform
  2015-11-05 · Reviewed-by
• STALE3954d REVIEWED: 3 (3M) [PATCH v6.1 4/8] clk: rockchip: add clock controller for rk3036
  2015-11-04 · Reviewed-by
• STALE3954d REVIEWED: 3 (3M) [PATCH v6.1 3/8] clk: rockchip: add new pll-type for rk3036 and similar socs
  2015-11-04 · Reviewed-by
• STALE3954d REVIEWED: 3 (3M) [PATCH v6 4/8] clk: rockchip: add clock controller for rk3036
  2015-11-04 · Reviewed-by