--- v14
+++ v12
@@ -1,41 +1,20 @@
-Here comes the 14th iteration of the patch. This new version addresses
-the comments received from Jimmy and Marc (thanks again for the
-review!).
+Here comes the twelfth iteration of the ETAS es58x usb driver. The
+major difference from previous version is the total removal of
+spinlocks. Aside of that, I also implemented the TDC accordingly to
+the patch series which I submitted here two weeks ago.
-** Changelog **
+This patch series is based on linux-can-next/testing. It requires the
+latest patches in that branch to compile.
-Changes in v14 (2021-03-21):
- - Rework the split into core support, es581_4, es58x_fd (cosmetic
- change) so that es581_4.h and es58x_fd.h headers can be added in
- one block.
- - Add a fourth patch to introduce a helper function
- es58x_netdev_queue_set_dql_min_limit() to set up dql minimum limit
- (in parallel, I will try to have this merged in the network device
- header)
- - Remove unused function es58x_add_skb_idx(): leftover from the old
- FIFO logic, should have been removed in v11.
- - Fix memory leak in es58x_get_product_info(): buffer was not freed
- in case of error in usb_sting().
- - s/loopback/echo and s/self reception/echo: in the driver the terms
- "loopback, self reception, and echo" were all used to designated
- the same thing. Renamed structures, variables and comments
- accordingly to make it more consistent.
- - Remove CAN_CTRLMODE_LOOPBACK. The driver never supported this
- feature. It was added due to a confusion with the echo skb.
- - Use the new can_free_echo_skb() which return the frame_len.
- - Do the statistics handling in es58x_rx_err_msg() even if kalloc()
- fails.
- - Replace array es58x_cmd_ret_desc[] by helper function
- es58x_cmd_ret_desc().
- - Other trivial changes (c.f. below link for details)
-Reference: https://lore.kernel.org/linux-can/50850e5f-87c6-505e-4398-babce3facb97@pengutronix.de/T/#mbcace9c13b19a504cd28d81591f983b95eb66657
+Crossing fingers, hoping that we are now close to a release.
-Changes in v13 (2021-03-19 by Marc Kleine-Budde):
- - split the driver into 3 patches, so that it can be send via
- mailing lists (core support, es581_4, es58x_fd)
- - Remove the dql.min_limit settings
- - typo and kernel doc fixes
-Reference: https://lore.kernel.org/linux-can/50850e5f-87c6-505e-4398-babce3facb97@pengutronix.de/T/#t
+Thank you in advance for your review and for your time!
+
+
+Yours sincerely,
+Vincent
+
+** Change log **
Changes in v12 (2021-03-09):
- Rework the queue stop/wake management so that spinlocks are not
@@ -112,22 +91,20 @@
v1 (2020-09-27):
- First release
-Vincent Mailhol (4):
- can: etas_es58x: add core support for ETAS ES58X CAN USB interfaces
- can: etas_es58x: add support for ETAS ES581.4 CAN USB interface
- can: etas_es58x: add support for the ETAS ES58X_FD CAN USB interfaces
- can: etas_es58x: add es58x_netdev_queue_set_dql_min_limit()
+
+Vincent Mailhol (1):
+ can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces
drivers/net/can/usb/Kconfig | 10 +
drivers/net/can/usb/Makefile | 1 +
drivers/net/can/usb/etas_es58x/Makefile | 3 +
- drivers/net/can/usb/etas_es58x/es581_4.c | 501 ++++
- drivers/net/can/usb/etas_es58x/es581_4.h | 207 ++
- drivers/net/can/usb/etas_es58x/es58x_core.c | 2403 +++++++++++++++++++
- drivers/net/can/usb/etas_es58x/es58x_core.h | 696 ++++++
- drivers/net/can/usb/etas_es58x/es58x_fd.c | 577 +++++
+ drivers/net/can/usb/etas_es58x/es581_4.c | 525 ++++
+ drivers/net/can/usb/etas_es58x/es581_4.h | 208 ++
+ drivers/net/can/usb/etas_es58x/es58x_core.c | 2404 +++++++++++++++++++
+ drivers/net/can/usb/etas_es58x/es58x_core.h | 690 ++++++
+ drivers/net/can/usb/etas_es58x/es58x_fd.c | 600 +++++
drivers/net/can/usb/etas_es58x/es58x_fd.h | 243 ++
- 9 files changed, 4641 insertions(+)
+ 9 files changed, 4684 insertions(+)
create mode 100644 drivers/net/can/usb/etas_es58x/Makefile
create mode 100644 drivers/net/can/usb/etas_es58x/es581_4.c
create mode 100644 drivers/net/can/usb/etas_es58x/es581_4.h