[PATCH 0708/1285] Replace numeric parameter like 0444 with macro

From: Baole Ni <hidden>
Date: 2016-08-02 16:15:50
Also in: lkml, netdev
Subsystem: can network drivers, the rest · Maintainers: Marc Kleine-Budde, Vincent Mailhol, Linus Torvalds

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <redacted>
Signed-off-by: Baole Ni <redacted>
---
 drivers/net/can/led.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/led.c b/drivers/net/can/led.c
index c1b6676..c602b9e 100644
--- a/drivers/net/can/led.c
+++ b/drivers/net/can/led.c
@@ -17,7 +17,7 @@
 #include <linux/can/led.h>
 
 static unsigned long led_delay = 50;
-module_param(led_delay, ulong, 0644);
+module_param(led_delay, ulong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(led_delay,
 		"blink delay time for activity leds (msecs, default: 50).");
 
-- 
2.9.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help