On 10/26/2012 10:01 AM, Stephane Grosjean wrote:

Hi Wolfgang,
Hi everybody,

Well the "push PATCH" method is bit too formal, it should exist a field
where to say "Hello guys, how are you since last time ? Sorry to disturb
you again, but I'd like to push..." ;-)

:D

If you want to add some prose text to the patch, that should not go into
the commit message you simply add it between the "---" and the diffstat:

Signed-off-by: Stephane Grosjean <redacted>
---

...here...

 drivers/net/can/sja1000/peak_pci.c |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

Le 24/10/2012 08:29, Wolfgang Grandegger a écrit :

quoted

Hi Stephane,

On 10/23/2012 12:37 PM, Stephane Grosjean wrote:
    MODULE_AUTHOR("Wolfgang Grandegger [off-list ref]");
+MODULE_AUTHOR("Stephane Grosjean [off-list ref]");
Hm, does adding a second MODULE_AUTHOR work? Anyway, feel free to remove
my line.

Yes it does:

$ modinfo peak_pci.ko
filename:       peak_pci.ko
license:        GPL v2
description:    Socket-CAN driver for PEAK PCAN PCI family cards
author:         Stephane Grosjean [off-list ref]
author:         Wolfgang Grandegger [off-list ref]
srcversion:     72C217A41A3CA4ABBFEAFDB
alias:          pci:v0000001Cd00000002sv*sd*bc*sc*i*
alias:          pci:v0000001Cd00000004sv*sd*bc*sc*i*
alias:          pci:v0000001Cd00000007sv*sd*bc*sc*i*
alias:          pci:v0000001Cd00000006sv*sd*bc*sc*i*
alias:          pci:v0000001Cd00000008sv*sd*bc*sc*i*
alias:          pci:v0000001Cd00000005sv*sd*bc*sc*i*
alias:          pci:v0000001Cd00000003sv*sd*bc*sc*i*
alias:          pci:v0000001Cd00000001sv*sd*bc*sc*i*
depends:        sja1000,i2c-algo-bit
vermagic:       3.0.0-14-generic-pae SMP mod_unload modversions 686

(well, don't ask me why my name comes before yours ;-) Maybe the
alphabetic order is used instead of the declaration order...)

So, for me there is no need (and I don't want) to remove yours.

I've replaced you as the author and the patch is already in David
Millers net tree.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |