Reviews by sagi@grimberg.me
· linux-block
All review-attestation trailers
(Reviewed-by / Acked-by /
Tested-by / Reported-by /
Suggested-by / Co-developed-by /
Reported-and-tested-by)
by this address on the linux-block archive.
100 attestations · capped at 100 most-recent. (1 Acked-by, 1 Reported-by, 97 Reviewed-by, 1 Suggested-by)
-
COLD51d
REVIEWED: 10 (9M) [PATCH V4 3/3] nvme-multipath: enable PCI P2PDMA for multipath devices
2026-05-13 · Reviewed-by -
COLD51d
REVIEWED: 10 (9M) [PATCH V4 2/3] md: propagate BLK_FEAT_PCI_P2PDMA from member devices to RAID device
2026-05-13 · Reviewed-by -
COLD51d
REVIEWED: 10 (9M) [PATCH V4 1/3] block: clear BLK_FEAT_PCI_P2PDMA in blk_stack_limits() for non-supporting devices
2026-05-13 · Reviewed-by -
STALE100d
REVIEWED: 6 (6M) [PATCH 6.1.y v2 4/6] nvme-pci: put the admin queue in nvme_dev_remove_admin
2026-04-02 · Reviewed-by -
STALE100d
REVIEWED: 6 (6M) [PATCH 6.1.y v2 3/6] nvme-pci: remove an extra queue reference
2026-04-02 · Reviewed-by -
STALE100d
REVIEWED: 6 (6M) [PATCH 6.1.y v2 2/6] blk-mq: move the call to blk_put_queue out of blk_mq_destroy_queue
2026-04-02 · Reviewed-by -
STALE105d
REVIEWED: 6 (6M) [PATCH 6.1.y 4/8] nvme-pci: remove an extra queue reference
2026-04-01 · Reviewed-by -
STALE105d
REVIEWED: 7 (6M) [PATCH 6.1.y 5/8] nvme-apple: remove an extra queue reference
2026-04-01 · Reviewed-by -
STALE105d
REVIEWED: 6 (6M) [PATCH 6.1.y 6/8] nvme-pci: put the admin queue in nvme_dev_remove_admin
2026-04-01 · Reviewed-by -
STALE105d
REVIEWED: 6 (6M) [PATCH 6.1.y 3/8] scsi: remove an extra queue reference
2026-04-01 · Reviewed-by -
STALE105d
REVIEWED: 6 (6M) [PATCH 6.1.y 2/8] blk-mq: move the call to blk_put_queue out of blk_mq_destroy_queue
2026-04-01 · Reviewed-by -
STALE222d
REVIEWED: 4 (4M) Re: [PATCH v2 12/12] nvmet: use bio_chain_and_submit to simplify bio chaining
2025-11-30 · Acked-by -
STALE228d
REVIEWED: 4 (4M) Re: [PATCH v2 1/1] nvme: Convert tag_list mutex to rwsemaphore to avoid deadlock
2025-11-30 · Reviewed-by -
STALE444d
REVIEWED: 4 (4M) Re: [RFC PATCHv2 3/3] nvme: rename nvme_mpath_shutdown_disk to nvme_mpath_remove_disk
2025-04-25 · Reviewed-by -
STALE428d
REVIEWED: 10 (10M) [PATCH v6 7/9] lib/group_cpus: honor housekeeping config when grouping CPUs
2025-04-24 · Reviewed-by -
STALE532d
REVIEWED: 4 (4M) Re: [PATCH 2/3] nvme-fc: use ctrl state getter
2025-01-31 · Reviewed-by -
STALE532d
REVIEWED: 4 (4M) Re: [PATCH 1/3] nvme-tcp: rate limit error message in send path
2025-01-31 · Reviewed-by -
STALE550d
REVIEWED: 10 (10M) [PATCH v5 6/9] lib/group_cpus: honor housekeeping config when grouping CPUs
2025-01-10 · Reviewed-by -
STALE529d
REVIEWED: 4 (4M) Re: [PATCH 2/2] block: remove blk_rq_bio_prep
2025-01-04 · Reviewed-by -
STALE529d
REVIEWED: 8 (8M) Re: [PATCH 1/2] block: remove bio_add_pc_page
2025-01-04 · Reviewed-by -
STALE529d
REVIEWED: 8 (8M) Re: [PATCH 1/2] block: remove bio_add_pc_page
2025-01-04 · Reviewed-by -
STALE550d
REVIEWED: 10 (10M) [PATCH v4 7/9] lib/group_cpus: honor housekeeping config when grouping CPUs
2024-12-17 · Reviewed-by -
STALE724d
REVIEWED: 10 (10M) [PATCH v6 2/3] nvme-tcp: use sendpages_ok() instead of sendpage_ok()
2024-07-23 · Reviewed-by -
STALE724d
REVIEWED: 20 (20M) [PATCH v6 1/3] net: introduce helper sendpages_ok()
2024-07-23 · Reviewed-by -
STALE724d
LANDED: 10 (10M) [PATCH v5 2/3] nvme-tcp: use sendpages_ok() instead of sendpage_ok()
2024-07-18 · Reviewed-by -
STALE724d
LANDED: 8 (8M) [PATCH v5 1/3] net: introduce helper sendpages_ok()
2024-07-18 · Reviewed-by -
STALE746d
REVIEWED: 4 (4M) Re: [PATCH 3/3] nvme: don't set io_opt if NOWS is zero
2024-07-01 · Reviewed-by -
STALE746d
REVIEWED: 4 (4M) Re: [PATCH 2/3] block: don't reduce max_sectors based on io_opt
2024-07-01 · Reviewed-by -
STALE746d
REVIEWED: 4 (4M) Re: [PATCH 1/3] block: remove a duplicate io_min check in blk_validate_limits
2024-07-01 · Reviewed-by -
STALE745d
REVIEWED: 4 (4M) Re: [PATCH v2 3/3] lib/group_cpus.c: honor housekeeping config when grouping CPUs
2024-06-30 · Reviewed-by -
STALE745d
REVIEWED: 4 (4M) Re: [PATCH v2 2/3] nvme-pci: limit queue count to housekeeping CPUs
2024-06-30 · Reviewed-by -
STALE745d
REVIEWED: 4 (4M) Re: [PATCH v2 1/3] blk-mq: add blk_mq_num_possible_queues helper
2024-06-30 · Reviewed-by -
STALE758d
REVIEWED: 4 (4M) Re: [PATCHv3 blktests] nvme: add test for creating/deleting file-ns
2024-06-19 · Reviewed-by -
STALE729d
REVIEWED: 10 (10M) [PATCH v4 2/4] nvme-tcp: use sendpages_ok() instead of sendpage_ok()
2024-06-11 · Reviewed-by -
STALE729d
REVIEWED: 8 (8M) [PATCH v4 1/4] net: introduce helper sendpages_ok()
2024-06-11 · Reviewed-by -
STALE766d
REVIEWED: 4 (4M) Re: [PATCH v3 2/4] nvme-tcp: use sendpages_ok() instead of sendpage_ok()
2024-06-10 · Reviewed-by -
STALE766d
REVIEWED: 4 (4M) Re: [PATCH v3 1/4] net: introduce helper sendpages_ok()
2024-06-10 · Reviewed-by -
STALE658d
LANDED: 7 (7M) [PATCH v2 3/3] nvme: allow integrity when PI is not in first bytes
2024-02-01 · Reviewed-by -
STALE658d
LANDED: 6 (6M) [PATCH v2 2/3] block: support PI at non-zero offset within metadata
2024-02-01 · Reviewed-by -
STALE658d
LANDED: 11 (11M) [PATCH v2 1/3] block: refactor guard helpers
2024-02-01 · Reviewed-by -
STALE898d
REVIEWED: 4 (4M) Re: [PATCH 3/3] nvme: allow integrity when PI is not in first bytes
2024-01-31 · Reviewed-by -
STALE898d
REVIEWED: 4 (4M) Re: [PATCH 2/3] block: support PI at non-zero offset within metadata
2024-01-31 · Reviewed-by -
STALE898d
REVIEWED: 4 (4M) Re: [PATCH 1/3] block: refactor guard helpers
2024-01-31 · Reviewed-by -
STALE1101d
REVIEWED: 4 (4M) Re: [PATCH 4/4] nvme: simplify the max_discard_segments calculation
2023-07-10 · Reviewed-by -
STALE1101d
REVIEWED: 4 (4M) Re: [PATCH 3/4] nvme: fix max_discard_sectors calculation
2023-07-10 · Reviewed-by -
STALE1101d
REVIEWED: 4 (4M) Re: [PATCH 2/4] nvme: update discard limits in nvme_config_discard
2023-07-10 · Reviewed-by -
STALE1101d
REVIEWED: 4 (4M) Re: [PATCH 1/4] block: don't unconditionally set max_discard_sectors in blk_queue_max_discard_sectors
2023-07-10 · Reviewed-by -
STALE1115d
REVIEWED: 4 (4M) Re: [PATCHv3 2/2] nvme: improved uring polling
2023-06-13 · Reviewed-by -
STALE1115d
LANDED: 9 (8M) [PATCHv3 1/2] block: add request polling helper
2023-06-12 · Reviewed-by -
DORMANTno replies
REVIEWED: 4 (4M) Re: [PATCHv2 1/2] block: add request polling helper
2023-06-11 · Reviewed-by -
STALE1134d
REVIEWED: 4 (4M) Re: [PATCH v4 1/1] nvmet-fcloop: Do not wait on completion when unregister fails
2023-06-07 · Reviewed-by -
DORMANTno replies
REVIEWED: 4 (4M) Re: [PATCH 2/2] nvme: improved uring polling
2023-06-05 · Reviewed-by -
STALE1138d
REVIEWED: 4 (4M) Re: [PATCH 1/2] block: add request polling helper
2023-06-05 · Reviewed-by -
STALE1180d
REVIEWED: 4 (4M) Re: [PATCH v1 2/2] nvme-multipath: fix path failover for integrity ns
2023-04-23 · Reviewed-by -
STALE1200d
LANDED: 11 (9M) [PATCHv2] blk-mq: directly poll requests
2023-03-31 · Reviewed-by -
STALE1204d
REVIEWED: 4 (4M) Re: [PATCH 3/3] blk-mq: directly poll requests
2023-03-22 · Reviewed-by -
STALE1333d
LANDED: 9 (7M) [PATCH 13/14] blk-mq: add tagset quiesce interface
2022-11-01 · Reviewed-by -
STALE1333d
LANDED: 8 (7M) [PATCH 14/14] nvme: use blk_mq_[un]quiesce_tagset
2022-11-01 · Reviewed-by -
STALE1333d
LANDED: 8 (7M) [PATCH 12/14] blk-mq: pass a tagset to blk_mq_wait_quiesce_done
2022-11-01 · Reviewed-by -
STALE1333d
LANDED: 9 (7M) [PATCH 11/14] blk-mq: move the srcu_struct used for quiescing to the tagset
2022-11-01 · Reviewed-by -
STALE1333d
LANDED: 8 (7M) [PATCH 10/14] blk-mq: skip non-mq queues in blk_mq_quiesce_queue
2022-11-01 · Reviewed-by -
STALE1333d
LANDED: 4 (4M) [PATCH 09/14] nvme-apple: don't unquiesce the I/O queues in apple_nvme_reset_work
2022-11-01 · Reviewed-by -
STALE1333d
LANDED: 4 (4M) [PATCH 07/14] nvme: split nvme_kill_queues
2022-11-01 · Reviewed-by -
STALE1333d
LANDED: 4 (4M) [PATCH 06/14] nvme: don't unquiesce the admin queue in nvme_kill_queues
2022-11-01 · Reviewed-by -
STALE1333d
LANDED: 4 (4M) [PATCH 04/14] nvme: remove the NVME_NS_DEAD check in nvme_remove_invalid_namespaces
2022-11-01 · Reviewed-by -
STALE1333d
LANDED: 4 (4M) [PATCH 03/14] nvme: don't remove namespaces in nvme_passthru_end
2022-11-01 · Reviewed-by -
STALE1333d
LANDED: 7 (5M) [PATCH 01/14] block: set the disk capacity to 0 in blk_mark_disk_dead
2022-11-01 · Reviewed-by -
STALE1356d
REVIEWED: 4 (4M) Re: [PATCH 17/17] nvme: use blk_mq_[un]quiesce_tagset
2022-10-26 · Reviewed-by -
STALE1356d
REVIEWED: 4 (4M) Re: [PATCH 12/17] nvme-pci: don't unquiesce the I/O queues in apple_nvme_reset_work
2022-10-26 · Reviewed-by -
STALE1356d
REVIEWED: 4 (4M) Re: [PATCH 09/17] nvme: don't unquiesce the I/O queues in nvme_kill_queues
2022-10-26 · Reviewed-by -
STALE1356d
REVIEWED: 4 (4M) Re: [PATCH 08/17] nvme: don't unquiesce the admin queue in nvme_kill_queues
2022-10-26 · Reviewed-by -
STALE1356d
REVIEWED: 4 (4M) Re: [PATCH 06/17] nvme: remove the NVME_NS_DEAD check in nvme_remove_invalid_namespaces
2022-10-26 · Reviewed-by -
STALE1356d
REVIEWED: 4 (4M) Re: [PATCH 05/17] nvme: don't remove namespaces in nvme_passthru_end
2022-10-26 · Reviewed-by -
STALE1356d
REVIEWED: 4 (4M) Re: [PATCH 03/17] nvme-pci: don't warn about the lack of I/O queues for admin controllers
2022-10-26 · Reviewed-by -
STALE1356d
REVIEWED: 4 (4M) Re: [PATCH 01/17] block: set the disk capacity to 0 in blk_mark_disk_dead
2022-10-26 · Reviewed-by -
STALE1356d
REVIEWED: 9 (7M) [PATCH 14/17] blk-mq: move the srcu_struct used for quiescing to the tagset
2022-10-25 · Reviewed-by -
STALE1356d
REVIEWED: 8 (7M) [PATCH 15/17] blk-mq: pass a tagset to blk_mq_wait_quiesce_done
2022-10-25 · Reviewed-by -
STALE1356d
REVIEWED: 9 (7M) [PATCH 16/17] blk-mq: add tagset quiesce interface
2022-10-25 · Reviewed-by -
STALE1356d
REVIEWED: 8 (7M) [PATCH 13/17] blk-mq: skip non-mq queues in blk_mq_quiesce_queue
2022-10-25 · Reviewed-by -
STALE1356d
REVIEWED: 7 (5M) [PATCH 01/17] block: set the disk capacity to 0 in blk_mark_disk_dead
2022-10-25 · Reviewed-by -
STALE1362d
REVIEWED: 4 (4M) Re: [PATCH 5/8] blk-mq: add tagset quiesce interface
2022-10-20 · Reviewed-by -
STALE1362d
REVIEWED: 4 (4M) Re: [PATCH 4/8] blk-mq: pass a tagset to blk_mq_wait_quiesce_done
2022-10-20 · Reviewed-by -
STALE1362d
REVIEWED: 4 (4M) Re: [PATCH 3/8] blk-mq: move the srcu_struct used for quiescing to the tagset
2022-10-20 · Reviewed-by -
STALE1362d
REVIEWED: 4 (4M) Re: [PATCH 2/8] blk-mq: skip non-mq queues in blk_mq_quiesce_queue
2022-10-20 · Reviewed-by -
STALE1362d
REVIEWED: 4 (4M) Re: [PATCH 1/8] block: set the disk capacity to 0 in blk_mark_disk_dead
2022-10-20 · Reviewed-by -
STALE1361d
REVIEWED: 4 (4M) Re: [PATCH 4/4] nvme-apple: remove an extra queue reference
2022-10-19 · Reviewed-by -
STALE1361d
REVIEWED: 4 (4M) Re: [PATCH 3/4] nvme-pci: remove an extra queue reference
2022-10-19 · Reviewed-by -
STALE1361d
REVIEWED: 4 (4M) Re: [PATCH 2/4] scsi: remove an extra queue reference
2022-10-19 · Reviewed-by -
STALE1361d
REVIEWED: 4 (4M) Re: [PATCH 1/4] blk-mq: move the call to blk_put_queue out of blk_mq_destroy_queue
2022-10-19 · Reviewed-by -
STALE1388d
REVIEWED: 4 (4M) Re: [PATCH 5/5] nvme: enable batched completions of passthrough IO
2022-09-28 · Reviewed-by -
STALE1388d
REVIEWED: 4 (4M) Re: [PATCH 4/5] nvme: split out metadata vs non metadata end_io uring_cmd completions
2022-09-28 · Reviewed-by -
STALE1415d
[PATCH blktests] nvme/043,044,045: load dh_generic module
2022-08-31 · Reported-by -
STALE1426d
REVIEWED: 4 (4M) Re: [PATCH v2 2/2] block: Change the return type of blk_mq_map_queues() into void
2022-08-17 · Reviewed-by -
STALE1459d
LANDED: 4 (4M) [PATCH v3 37/63] nvme/host: Use the enum req_op and blk_opf_t types
2022-07-14 · Reviewed-by -
STALE1460d
[PATCH for-next 4/4] nvme-multipath: add multipathing for uring-passthrough commands
2022-07-11 · Suggested-by -
STALE1465d
REVIEWED: 4 (4M) [PATCH v2 38/63] nvme/target: Use the new blk_opf_t type
2022-06-29 · Reviewed-by -
STALE1465d
REVIEWED: 4 (4M) [PATCH v2 37/63] nvme/host: Use the enum req_op and blk_opf_t types
2022-06-29 · Reviewed-by -
DORMANTno replies
REVIEWED: 4 (4M) Re: [bug report] kmemleak observed from blktests on latest linux-block/for-next
2022-06-26 · Reviewed-by -
STALE1480d
REVIEWED: 4 (4M) Re: [PATCH v2 5/6] blk-mq: Drop 'reserved' arg of busy_tag_iter_fn
2022-06-26 · Reviewed-by -
STALE1480d
REVIEWED: 4 (4M) Re: [PATCH 28/51] nvme/target: Use the new blk_opf_t type
2022-06-26 · Reviewed-by