[PATCH linux-next] loop: Remove redundant assignments and parentheses
From: <hidden>
Date: 2021-12-08 07:55:03
Also in:
lkml
Subsystem:
block layer, the rest · Maintainers:
Jens Axboe, Linus Torvalds
From: luo penghao <redacted> The assignment of node has been done during initialization, and the parentheses are meaningless according to the priority. drivers/block/loop.c:1001:19: warning Value stored to 'node' during its initialization is never read Reported-by: Zeal Robot <redacted> Signed-off-by: luo penghao <redacted> --- drivers/block/loop.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index dfc72a1..0b74cbe 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c@@ -985,7 +985,7 @@ static inline int queue_on_root_worker(struct cgroup_subsys_state *css) static void loop_queue_work(struct loop_device *lo, struct loop_cmd *cmd) { - struct rb_node **node = &(lo->worker_tree.rb_node), *parent = NULL; + struct rb_node **node = &lo->worker_tree.rb_node, *parent = NULL; struct loop_worker *cur_worker, *worker = NULL; struct work_struct *work; struct list_head *cmd_list;
@@ -995,8 +995,6 @@ static void loop_queue_work(struct loop_device *lo, struct loop_cmd *cmd) if (queue_on_root_worker(cmd->blkcg_css)) goto queue_work; - node = &lo->worker_tree.rb_node; - while (*node) { parent = *node; cur_worker = container_of(*node, struct loop_worker, rb_node);
--
2.15.2