Re: [PATCH] fs: kill unused ret2 argument from iocb->ki_complete()

Jens Axboe [off-list ref] writes:

On 10/20/21 1:11 PM, Jeff Moyer wrote:

quoted

Jens Axboe [off-list ref] writes:

quoted

On 10/20/21 12:41 PM, Jens Axboe wrote:

quoted

Working on just changing it to a 64-bit type instead, then we can pass
in both at once with res2 being the upper 32 bits. That'll keep the same
API on the aio side.

Here's that as an incremental. Since we can only be passing in 32-bits
anyway across 32/64-bit, we can just make it an explicit 64-bit instead.
This generates the same code on 64-bit for calling ->ki_complete, and we
can trivially ignore the usb gadget issue as we now can pass in both
values (and fill them in on the aio side).

Yeah, I think that should work.

Passed test and allmodconfig sanity check, sent out as v2 :)

It passed the libaio tests on x64.  I'll do some more testing and review
the v2 posting.

Thanks!
Jeff

On 10/20/21 1:47 PM, Jeff Moyer wrote:

Jens Axboe [off-list ref] writes:

quoted

On 10/20/21 1:11 PM, Jeff Moyer wrote:

quoted

Jens Axboe [off-list ref] writes:

quoted

On 10/20/21 12:41 PM, Jens Axboe wrote:

quoted

Working on just changing it to a 64-bit type instead, then we can pass
in both at once with res2 being the upper 32 bits. That'll keep the same
API on the aio side.

Here's that as an incremental. Since we can only be passing in 32-bits
anyway across 32/64-bit, we can just make it an explicit 64-bit instead.
This generates the same code on 64-bit for calling ->ki_complete, and we
can trivially ignore the usb gadget issue as we now can pass in both
values (and fill them in on the aio side).

Yeah, I think that should work.

Passed test and allmodconfig sanity check, sent out as v2 :)

It passed the libaio tests on x64.  I'll do some more testing and review
the v2 posting.

Thanks Jeff!

-- 
Jens Axboe