# Re: \[PATCH 01/17\] mm: don't include \<linux/blk-cgroup.h\> in \<linux/writeback.h\>

- From: Johannes Thumshirn \<hidden\>
- Date: 2021-09-15 08:51:18 
- List: linux-block
- Page: https://ratatoskr.run/linux-block/2021/09/6405421
- Thread: https://ratatoskr.run/linux-block/2021/09/6405397/t.md

```text
On 15/09/2021 10:49, Christoph Hellwig wrote:
> 
> .. but they aren't.  All these headers indirectl pulled these headers
> in before and now don't.
> 
> random32.c pulls in writeback.h through trace/events/random.h, which
> pulls in blk-cgroup.h, which pull in blkdev.h, which pulls in slab.h
> through some other weird twist of fate.
> 
> The drm code also somehow manages to pull in writeback.h
> 

Sh*t didn't notice that. But this doesn't sound healthy.
```
