# Re: \[PATCH 13/13\] xfs: convert xfs\_sysfs attrs to use -\>seq\_show

- From: Christoph Hellwig \<hch@lst.de\>
- Date: 2021-09-15 07:04:54 
- List: linux-block
- Page: https://ratatoskr.run/linux-block/2021/09/214275
- Thread: https://ratatoskr.run/linux-block/2021/09/214031/t.md

```text
On Tue, Sep 14, 2021 at 05:41:37PM +0200, Greg Kroah-Hartman wrote:
> They huge majority of sysfs attributes are "trivial".  So for maybe at
> least 95% of the users, if not more, using sysfs_emit() is just fine as
> all you "should" be doing is emitting a single value.

It is just fine if no one does the obvious mistakes that an interface
with a char * pointer leads to.  And 5% of all attributes is still a huge
attack surface.
```