# Re: \[PATCH v4\] block: genhd: don't call probe function with major\_names\_lock held

- From: Tetsuo Handa \<penguin-kernel@i-love.sakura.ne.jp\>
- Date: 2021-08-19 14:47:37 
- List: linux-block
- Page: https://ratatoskr.run/linux-block/2021/08/6404857
- Thread: https://ratatoskr.run/linux-block/2021/06/1419777/t.md

```text
On 2021/08/19 18:16, Christoph Hellwig wrote:
> On Wed, Aug 18, 2021 at 11:51:24PM +0900, Tetsuo Handa wrote:
>> The loop module is one of critical components for syzkaller fuzzing.
>> Bugs which involves the loop module prevents syzkaller from finding/testing
>> other bugs. But changes are continuously applied without careful review.
>> Therefore, the changes and code are not getting correct. Stable work cannot
>> come afterwards...
> 
> I know a very simple solution: review them and provide detailed feedback.
> It's not like patches just appear in a tree somewhere.
> 

You don't know, and nobody knows, a simple solution that can apply to my case:

  I'm not your exclusive reviewer, and I'm not familiar with the block layer.
  Actually, I'm not a developer living in block layer, and I'm not subscribed
  to linux-block mailing list. I check bugs reported by syzbot, and analyze
  and try to write patches. I can't afford monitoring patches of all mailing
  lists.

  In order words, I can't review your patches and can't provide detailed feedback
  (unless you cc me with detailed explanation of why it is safe to make such change).

Bugs are merged everywhere but I can't prevent bugs from getting merged. I monitor
bugs reported by syzbot. It is exactly like patches just appear in a tree somewhere.

```