# Re: \[PATCH v2 03/11\] blk-mq: Relocate shared sbitmap resize in blk\_mq\_update\_nr\_requests()

- From: Ming Lei \<hidden\>
- Date: 2021-08-18 03:50:11 
- List: linux-block
- Page: https://ratatoskr.run/linux-block/2021/08/1481105
- Thread: https://ratatoskr.run/linux-block/2021/08/1471972/t.md

```text
On Mon, Aug 09, 2021 at 10:29:30PM +0800, John Garry wrote:
> For shared sbitmap, if the call to blk_mq_tag_update_depth() was
> successful for any hctx when hctx->sched_tags is not set, then it would be
> successful for all (due to nature in which blk_mq_tag_update_depth()
> fails).
> 
> As such, there is no need to call blk_mq_tag_resize_shared_sbitmap() for
> each hctx. So relocate the call until after the hctx iteration under the
> !q->elevator check, which is equivalent (to !hctx->sched_tags).
> 
> Signed-off-by: John Garry <redacted>

Reviewed-by: Ming Lei <redacted>

-- 
Ming

```