two bsg fixes
From: Christoph Hellwig <hch@lst.de>
Date: 2021-07-31 07:41:22
Hi Martin, this series contains two small fixes for commands without data transfer for the recent bsg changes.
two bsg fixes
3 messages, 1 author, 2021-07-31 · open the first message on its own page
[PATCH 1/2] scsi: bsg: fix commands without data transfer in scsi_bsg_sg_io_fn
From: Christoph Hellwig <hch@lst.de>
Date: 2021-07-31 07:42:02
Set ret to 0 after the initial permission checks to avoid leaking
-EPERM for commands without data transfer.
Fixes: 75ca56409e5b ("scsi: bsg: Move the whole request execution into the SCSI/transport handlers")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/scsi/scsi_bsg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/scsi_bsg.c b/drivers/scsi/scsi_bsg.c
index d13a67b82429..81c3853a2a80 100644
--- a/drivers/scsi/scsi_bsg.c
+++ b/drivers/scsi/scsi_bsg.c@@ -47,6 +47,7 @@ static int scsi_bsg_sg_io_fn(struct request_queue *q, struct sg_io_v4 *hdr, if (!scsi_cmd_allowed(sreq->cmd, mode)) goto out_free_cmd; + ret = 0; if (hdr->dout_xfer_len) { ret = blk_rq_map_user(rq->q, rq, NULL, uptr64(hdr->dout_xferp), hdr->dout_xfer_len, GFP_KERNEL);
--
2.30.2
[PATCH 2/2] bsg-lib: fix commands without data transfer in bsg_transport_sg_io_fn
From: Christoph Hellwig <hch@lst.de>
Date: 2021-07-31 07:42:34
Set ret to 0 after the initial permission checks to avoid leaking
-EPERM for commands without data transfer.
Fixes: 75ca56409e5b ("scsi: bsg: Move the whole request execution into the SCSI/transport
handlers")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/bsg-lib.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/bsg-lib.c b/block/bsg-lib.c
index 239ebf747141..ccb98276c964 100644
--- a/block/bsg-lib.c
+++ b/block/bsg-lib.c@@ -72,6 +72,7 @@ static int bsg_transport_sg_io_fn(struct request_queue *q, struct sg_io_v4 *hdr, job->bidi_bio = NULL; } + ret = 0; if (hdr->dout_xfer_len) { ret = blk_rq_map_user(rq->q, rq, NULL, uptr64(hdr->dout_xferp), hdr->dout_xfer_len, GFP_KERNEL);
--
2.30.2