[PATCH] loop: remove unused variable in loop_set_status()

Subsystems: block layer, the rest · Maintainers: Jens Axboe, Linus Torvalds

STALE1942d LANDED

Status: Landed in mainline as 585af8ede703 on 2021-07-02.

4 messages, 3 authors, 2021-07-02 · open the first message on its own page

[PATCH] loop: remove unused variable in loop_set_status()

From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Date: 2021-07-02 15:27:58

Commit 0384264ea8a39bd9 ("block: pass a gendisk to bdev_disk_changed")
changed to pass lo->lo_disk instead of lo->lo_device.

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
---
 drivers/block/loop.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index cc0e8c39a48b..9f5a93688164 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1434,7 +1434,6 @@ static int
 loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
 {
 	int err;
-	struct block_device *bdev;
 	kuid_t uid = current_uid();
 	int prev_lo_flags;
 	bool partscan = false;
@@ -1503,7 +1502,6 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
 	if (!err && (lo->lo_flags & LO_FLAGS_PARTSCAN) &&
 	     !(prev_lo_flags & LO_FLAGS_PARTSCAN)) {
 		lo->lo_disk->flags &= ~GENHD_FL_NO_PART_SCAN;
-		bdev = lo->lo_device;
 		partscan = true;
 	}
 out_unlock:
-- 
2.18.4

Re: [PATCH] loop: remove unused variable in loop_set_status()

From: Jens Axboe <axboe@kernel.dk>
Date: 2021-07-02 15:29:26

On 7/2/21 9:27 AM, Tetsuo Handa wrote:
Commit 0384264ea8a39bd9 ("block: pass a gendisk to bdev_disk_changed")
changed to pass lo->lo_disk instead of lo->lo_device.
Applied, thanks.

-- 
Jens Axboe

Re: [PATCH] loop: remove unused variable in loop_set_status()

From: Christoph Hellwig <hch@lst.de>
Date: 2021-07-02 15:31:24

On Fri, Jul 02, 2021 at 09:29:26AM -0600, Jens Axboe wrote:
On 7/2/21 9:27 AM, Tetsuo Handa wrote:
quoted
Commit 0384264ea8a39bd9 ("block: pass a gendisk to bdev_disk_changed")
changed to pass lo->lo_disk instead of lo->lo_device.
Applied, thanks.
FYI, I also sent a patch on June 25th for this..

Re: [PATCH] loop: remove unused variable in loop_set_status()

From: Jens Axboe <axboe@kernel.dk>
Date: 2021-07-02 15:32:24

On 7/2/21 9:31 AM, Christoph Hellwig wrote:
On Fri, Jul 02, 2021 at 09:29:26AM -0600, Jens Axboe wrote:
quoted
On 7/2/21 9:27 AM, Tetsuo Handa wrote:
quoted
Commit 0384264ea8a39bd9 ("block: pass a gendisk to bdev_disk_changed")
changed to pass lo->lo_disk instead of lo->lo_device.
Applied, thanks.
FYI, I also sent a patch on June 25th for this..
Oops, looks like I missed that one.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help