# Re: \[PATCH 01/26\] block: refactor device number setup in \_\_device\_add\_disk

- From: Hannes Reinecke \<hare@suse.de\>
- Date: 2021-05-23 07:46:08 
- List: linux-block
- Page: https://ratatoskr.run/linux-block/2021/05/6402865
- Thread: https://ratatoskr.run/linux-block/2021/05/6402806/t.md

```text
On 5/21/21 7:50 AM, Christoph Hellwig wrote:
> Untangle the mess around blk_alloc_devt by moving the check for
> the used allocation scheme into the callers.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   block/blk.h             |  4 +-
>   block/genhd.c           | 96 ++++++++++++++++-------------------------
>   block/partitions/core.c | 15 +++++--
>   3 files changed, 49 insertions(+), 66 deletions(-)
>
... and also fixes an issue with GENHD_FL_UP remained set in an error path in __device_add_disk().

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
```