[PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared

Subsystems: block layer, the rest

STALE1986d LANDED

Landed in mainline as 39aa56db50b9 on 2021-04-06.

6 messages, 5 authors, 2021-04-06 · open the first message on its own page

[PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared

From: Nikolay Borisov <hidden>
Date: 2021-03-11 08:18:16 

Signed-off-by: Nikolay Borisov <redacted>
---
 block/blk-mq-tag.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index 9c92053e704d..99bc5fe14e9b 100644
--- a/block/blk-mq-tag.c
+++ b/block/blk-mq-tag.c
@@ -517,7 +517,7 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags,
 	tags->nr_tags = total_tags;
 	tags->nr_reserved_tags = reserved_tags;
 
-	if (flags & BLK_MQ_F_TAG_HCTX_SHARED)
+	if (blk_mq_is_sbitmap_shared(flags))
 		return tags;
 
 	if (blk_mq_init_bitmap_tags(tags, node, alloc_policy) < 0) {
@@ -529,7 +529,7 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags,
 
 void blk_mq_free_tags(struct blk_mq_tags *tags, unsigned int flags)
 {
-	if (!(flags & BLK_MQ_F_TAG_HCTX_SHARED)) {
+	if (!blk_mq_is_sbitmap_shared(flags)) {
 		sbitmap_queue_free(tags->bitmap_tags);
 		sbitmap_queue_free(tags->breserved_tags);
 	}
-- 
2.25.1

Re: [PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared

From: Johannes Thumshirn <hidden>
Date: 2021-03-11 08:26:18 

Looks good,
Reviewed-by: Johannes Thumshirn <redacted>

Re: [PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared

From: Nikolay Borisov <hidden>
Date: 2021-04-06 07:07:10 


On 11.03.21 г. 10:17, Nikolay Borisov wrote:
Signed-off-by: Nikolay Borisov <redacted>
Ping
quoted hunk
---
 block/blk-mq-tag.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index 9c92053e704d..99bc5fe14e9b 100644
--- a/block/blk-mq-tag.c
+++ b/block/blk-mq-tag.c
@@ -517,7 +517,7 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags,
 	tags->nr_tags = total_tags;
 	tags->nr_reserved_tags = reserved_tags;
 
-	if (flags & BLK_MQ_F_TAG_HCTX_SHARED)
+	if (blk_mq_is_sbitmap_shared(flags))
 		return tags;
 
 	if (blk_mq_init_bitmap_tags(tags, node, alloc_policy) < 0) {
@@ -529,7 +529,7 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags,
 
 void blk_mq_free_tags(struct blk_mq_tags *tags, unsigned int flags)
 {
-	if (!(flags & BLK_MQ_F_TAG_HCTX_SHARED)) {
+	if (!blk_mq_is_sbitmap_shared(flags)) {
 		sbitmap_queue_free(tags->bitmap_tags);
 		sbitmap_queue_free(tags->breserved_tags);
 	}

Re: [PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared

From: Hannes Reinecke <hare@suse.de>
Date: 2021-04-06 07:20:47 

On 3/11/21 9:17 AM, Nikolay Borisov wrote:
quoted hunk
Signed-off-by: Nikolay Borisov <redacted>
---
  block/blk-mq-tag.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index 9c92053e704d..99bc5fe14e9b 100644
--- a/block/blk-mq-tag.c
+++ b/block/blk-mq-tag.c
@@ -517,7 +517,7 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags,
  	tags->nr_tags = total_tags;
  	tags->nr_reserved_tags = reserved_tags;
  
-	if (flags & BLK_MQ_F_TAG_HCTX_SHARED)
+	if (blk_mq_is_sbitmap_shared(flags))
  		return tags;
  
  	if (blk_mq_init_bitmap_tags(tags, node, alloc_policy) < 0) {
@@ -529,7 +529,7 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags,
  
  void blk_mq_free_tags(struct blk_mq_tags *tags, unsigned int flags)
  {
-	if (!(flags & BLK_MQ_F_TAG_HCTX_SHARED)) {
+	if (!blk_mq_is_sbitmap_shared(flags)) {
  		sbitmap_queue_free(tags->bitmap_tags);
  		sbitmap_queue_free(tags->breserved_tags);
  	}
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

Re: [PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared

From: Himanshu Madhani <hidden>
Date: 2021-04-06 14:36:20 

quoted hunk
On Mar 11, 2021, at 2:17 AM, Nikolay Borisov [off-list ref] wrote:

Signed-off-by: Nikolay Borisov <redacted>
---
block/blk-mq-tag.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index 9c92053e704d..99bc5fe14e9b 100644
--- a/block/blk-mq-tag.c
+++ b/block/blk-mq-tag.c
@@ -517,7 +517,7 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags,
	tags->nr_tags = total_tags;
	tags->nr_reserved_tags = reserved_tags;

-	if (flags & BLK_MQ_F_TAG_HCTX_SHARED)
+	if (blk_mq_is_sbitmap_shared(flags))
		return tags;

	if (blk_mq_init_bitmap_tags(tags, node, alloc_policy) < 0) {
@@ -529,7 +529,7 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags,

void blk_mq_free_tags(struct blk_mq_tags *tags, unsigned int flags)
{
-	if (!(flags & BLK_MQ_F_TAG_HCTX_SHARED)) {
+	if (!blk_mq_is_sbitmap_shared(flags)) {
		sbitmap_queue_free(tags->bitmap_tags);
		sbitmap_queue_free(tags->breserved_tags);
	}
-- 
2.25.1
Looks Good. 

Reviewed-by: Himanshu Madhani <redacted>

--
Himanshu Madhani	 Oracle Linux Engineering






  

    
Re: [PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared

    

      From: Jens Axboe <axboe@kernel.dk>

      Date: 2021-04-06 15:24:42 
    

  

  
On 3/11/21 1:17 AM, Nikolay Borisov wrote:
Signed-off-by: Nikolay Borisov <redacted>
Applied, thanks.

-- 
Jens Axboe





    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help