# Re: \[PATCH\] block/umem: convert tasklet to threaded irq

- From: Jens Axboe \<axboe@kernel.dk\>
- Date: 2021-03-23 17:28:59 
- List: linux-block
- Page: https://ratatoskr.run/linux-block/2021/03/6312630
- Thread: https://ratatoskr.run/linux-block/2021/03/6311466/t.md

```text
On 3/23/21 11:24 AM, Christoph Hellwig wrote:
> On Mon, Mar 22, 2021 at 05:48:56PM -0700, Davidlohr Bueso wrote:
>> Tasklets have long been deprecated as being too heavy on the system
>> by running in irq context - and this is not a performance critical
>> path. If a higher priority process wants to run, it must wait for
>> the tasklet to finish before doing so. A more suitable equivalent
>> is to converted to threaded irq instead and deal with the async
>> processing in task context.
> 
> I'm really curious if this driver is still in use at all, or if we
> can drop it.

Me too, I'd be surprised if anyone has used it in... forever. We can
probably drop it - I really dislike making core changes to something
that can't even be tested. Davidlohr, assuming you had no way of
testing this change?

-- 
Jens Axboe

```
