[RFC PATCH 03/39] blkdev.h: add new trace ext as a queue member

Subsystems: block layer, the rest

STALE2064d

2 messages, 2 authors, 2021-02-26 · open the first message on its own page

[RFC PATCH 03/39] blkdev.h: add new trace ext as a queue member

From: Chaitanya Kulkarni <hidden>
Date: 2021-02-25 07:04:59 

Update a struct queue with block trace extension.

Signed-off-by: Chaitanya Kulkarni <redacted>
---
 include/linux/blkdev.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index c032cfe133c7..7c21f22f2077 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -533,6 +533,7 @@ struct request_queue {
 	struct mutex		debugfs_mutex;
 #ifdef CONFIG_BLK_DEV_IO_TRACE
 	struct blk_trace __rcu	*blk_trace;
+	struct blk_trace_ext __rcu	*blk_trace_ext;
 #endif
 	/*
 	 * for flush operations
-- 
2.22.1

Re: [RFC PATCH 03/39] blkdev.h: add new trace ext as a queue member

From: Damien Le Moal <hidden>
Date: 2021-02-26 04:36:25 

On 2021/02/25 16:03, Chaitanya Kulkarni wrote:
quoted hunk
Update a struct queue with block trace extension.

Signed-off-by: Chaitanya Kulkarni <redacted>
---
 include/linux/blkdev.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index c032cfe133c7..7c21f22f2077 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -533,6 +533,7 @@ struct request_queue {
 	struct mutex		debugfs_mutex;
 #ifdef CONFIG_BLK_DEV_IO_TRACE
 	struct blk_trace __rcu	*blk_trace;
+	struct blk_trace_ext __rcu	*blk_trace_ext;
 #endif
 	/*
 	 * for flush operations
You lost me here... why is blk_trace_ext defined in addition to the existing
blk_trace ? Why not extend the definition of struct blk_trace ?

And this patch should probably be squashed into patch 2.

-- 
Damien Le Moal
Western Digital Research
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help