# Re: \[PATCH v4 4/5\] nvme-rdma: avoid IO error for nvme native multipath

- From: Chao Leng \<hidden\>
- Date: 2021-01-28 09:34:57 
- List: linux-block
- Page: https://ratatoskr.run/linux-block/2021/01/6400601
- Thread: https://ratatoskr.run/linux-nvme/2021/01/6400526/t.md

```text


On 2021/1/28 16:39, Sagi Grimberg wrote:
>
>> @@ -2084,8 +2085,10 @@ static blk_status_t nvme_rdma_queue_rq(struct blk_mq_hw_ctx *hctx,
>>       err = nvme_rdma_post_send(queue, sqe, req->sge, req->num_sge,
>>               req->mr ? &req->reg_wr.wr : NULL);
>> -    if (unlikely(err))
>> +    if (unlikely(err)) {
>> +        driver_error = true;
>>           goto err_unmap;
>
> Why not just call set the status and call nvme_rdma_complete_rq and
> return here?
If the err is ENOMEM or EAGAIN, I am not sure the err must be a
path-related error for all HBA drivers. So reused the error check code.
I think it would be more reasonable to assume any errors returned by HBA
driver as path-related errors.
If you think so, I will modify it in next patch version.
```