# \[PATCH\] zram: fix NULL check before some freeing functions is not needed - Subsystems: BLOCK LAYER, THE REST, ZRAM COMPRESSED RAM BLOCK DEVICE DRVIER - Maintainers: Jens Axboe, Linus Torvalds, Minchan Kim, Sergey Senozhatsky - List: linux-block - 3 messages, 3 authors - Page: https://ratatoskr.run/linux-block/2021/01/6400534/t ## \[PATCH\] zram: fix NULL check before some freeing functions is not needed - From: Tian Tao \ - Date: 2021-01-26 19:54:08 - Message: https://ratatoskr.run/linux-block/2021/01/6400534.md ```text fixed the below warning: /drivers/block/zram/zram_drv.c:534:2-8: WARNING: NULL check before some freeing functions is not needed. Signed-off-by: Tian Tao --- drivers/block/zram/zram_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index e2933cb..92739b9 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -530,8 +530,7 @@ static ssize_t backing_dev_store(struct device *dev, return len; out: - if (bitmap) - kvfree(bitmap); + kvfree(bitmap); if (bdev) blkdev_put(bdev, FMODE_READ | FMODE_WRITE | FMODE_EXCL); -- 2.7.4 ``` ## Re: \[PATCH\] zram: fix NULL check before some freeing functions is not needed - From: Minchan Kim \ - Date: 2021-01-25 20:11:20 - Message: https://ratatoskr.run/linux-block/2021/01/6400485.md ```text On Mon, Jan 25, 2021 at 04:13:01PM +0800, Tian Tao wrote: > fixed the below warning: > /drivers/block/zram/zram_drv.c:534:2-8: WARNING: NULL check > before some freeing functions is not needed. > > Signed-off-by: Tian Tao Acked-by: Minchan Kim Thanks. ``` ## Re: \[PATCH\] zram: fix NULL check before some freeing functions is not needed - From: Jens Axboe \ - Date: 2021-01-26 22:08:48 - Message: https://ratatoskr.run/linux-block/2021/01/6400541.md ```text On 1/25/21 1:13 AM, Tian Tao wrote: > fixed the below warning: > /drivers/block/zram/zram_drv.c:534:2-8: WARNING: NULL check > before some freeing functions is not needed. Applied, thanks. -- Jens Axboe ```